Repository navigation
bug(security): upgrade mysql-connector-java to 8.0.16 (CVE-2019-2692) - #303
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes code-scan finding
sfind-eb08b49a(SnykSNYK-JAVA-MYSQL-174574, CVE-2019-2692, CVSS 6.3, privilege escalation inmysql:mysql-connector-java@5.1.42, pulled in transitively from the Spring Boot 1.5.4 BOM).<properties> <java.version>1.8</java.version> + <mysql.version>8.0.16</mysql.version> </properties>spring-boot-dependenciespinsmysql-connector-javato${mysql.version}, so overriding that property is enough. No coordinate change, no Boot upgrade, and no Java version change. 8.0.16 is the smallest version that fixes this CVE, and it still targets Java 8.Major bump (5.1 -> 8.0), flagged for review:
com.mysql.jdbc.Driveris still there in 8.0 as a deprecated shim, so Boot's auto-detected driver keeps working. It logs a deprecation warning at startup. Settingspring.datasource.driver-class-name=com.mysql.cj.jdbc.Driverwould silence it, but I left it out to keep this change minimal.serverTimezone=UTCtospring.datasource.url.com.mysql:mysql-connector-j8.2.0). Those are separate findings and are not covered here.Verification: limited. Please read before merging.
git-manager.devin.ai. Maven Central andapi.snyk.ioare blocked, and a request for access to them is pending.mvn clean compile/mvn testdid not run. Neither the Boot 1.5.4 parent nor Connector/J 8.0.16 is in the local~/.m2, and the only existing test is a@SpringBootTestcontext load that needs a live MySQLonlinebankingDB.snyk test --file=UserFront/pom.xmlalso failed on network, so I can't give before/after Snyk issue counts. The expected result is that this issue goes from 1 to 0 formysql-connector-java.spring-boot-dependenciesBOM managesmysql-connector-javavia${mysql.version}(confirmed on the cached 1.5.8 BOM), and none of the application code imports MySQL driver classes.cd UserFront && mvn clean testagainst MySQL, thensnyk test, before merging.Overlap: several open PRs switch to
com.mysql:mysql-connector-jas part of full Spring Boot 2.x/3.x upgrades (e.g. #33 pins 8.0.33, #109 pins 5.1.49, which does not fix this CVE). This PR is the minimal, standalone fix for this finding only.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/00f3696d3adb43809d708b1711765c56
Open in Devin Desktop: https://app.devin.ai/desktop/session/00f3696d3adb43809d708b1711765c56?variant=devin
Devin Review