Repository navigation
Conversation
The definition lacked LIBYANG_API_DEF, so the function declared in out.h was not exported from the shared library and programs calling it failed to link.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ly_out_memory()is declared withLIBYANG_API_DECLin out.h and listed among the output handler functions, but its definition in out.c lacksLIBYANG_API_DEF. The library is compiled with-fvisibility=hidden, so the default shared library does not export it and programs calling it fail to link:out_memory.cis any program calling it, e.g.:The unit tests build the library objects into the test binaries, so they do not notice.
Fix: add
LIBYANG_API_DEFto the definition, as for the other public functions (like #2297 forlyd_new_term_bin()).Tested on devel f45939c with clang 21 and the default CMake options:
ly_out_memoryis exported from libyang.so and the program above links and runs; withENABLE_TESTS=ONand-fsanitize=address,undefined,ctestpasses (70 tests).