Repository navigation
Conversation
…t_filepath() The new file was opened (and truncated) before the current stream was closed. When it was the same file, the data still buffered in the current stream were written into it on fclose() and remained after the new data. Flush the current stream first; it is still closed only after the new file is opened.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ly_out_filepath()opens the new path withfopen(filepath, "wb")and only then closes the current stream. When the new path is the current file (to start writing it again),fopen()truncates the file and the followingfclose()writes the data still buffered in the old stream into it, so they end up after the new data. The documentation says "the current file is closed and a new one is created/opened"; it does not say whether the new path may be the current one.On devel f45939c the file is
"new\nious data\n"instead of"new\n". It happens only with data written byly_write()/ly_print()and not flushed yet, the printer functions flush at their end.Fix: flush the current stream before opening the new file. The stream is still kept open until the new file is opened, so a failure to open the new path leaves the handler as it was. The new case in
test_output_filepathfails on the current tree and passes with the fix.Tested on devel f45939c with clang 21,
-fsanitize=address,undefined,ENABLE_TESTS=ON:ctestpasses (70 tests).