Repository navigation
Conversation
For a stream without a file descriptor (fmemopen(), open_memstream()) fileno() returns -1, which ly_in_fd() takes as a query of the current descriptor. ly_in_file() then returned the previous stream as if the input was changed and stored the new stream in the handler, while the handler kept reading the previous file. Return NULL and leave the handler untouched, as documented.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ly_in_file()documentsNULL in case of invalid argument or an error when setting up the new input file, original input handler @p in is untouched. Given a stream that has no file descriptor (fmemopen(),open_memstream(),fopencookie()), it instead returns the previous stream (success) and stores the new stream in the handler, while the handler keeps reading the previous file.ly_in_new_file()refuses the same stream withLY_EINVAL.On devel f45939c this prints:
A later
ly_in_file()call with a regular file then returns NULL (failure), although the handler does read the new file, and the handler still reports thefmemopen()stream.Cause:
ly_in_file()passesfileno(f)toly_in_fd(), and -1 there means "get the current descriptor", so the call succeeds without changing the input. The handler's stream is then replaced anyway.Fix: check
fileno(f)first and return NULL without touching the handler, with an error message. The new case intest_input_file(not on Windows) fails on the current tree and passes with the fix.Tested on devel f45939c with clang 21,
-fsanitize=address,undefined,ENABLE_TESTS=ON:ctestpasses (70 tests).