ci(release): install fpm for the release/package contract gate - #290
Merged
Conversation
The release path has been broken since 2026-07-24 and nobody could see it. Two of the contracts this job runs BUILD a .deb and inspect its payload — deb-reconciler-staging (#194, 07-24) and deb-sourcemap-policy (#288, 08-15) — but the job never installed fpm, so the first release attempt after #194 died at the first gate with "fpm not on PATH". The last successful release was 07-19, five days before that dependency arrived. It stayed invisible because build-check.yml's test-be job runs the SAME contract suite and DOES install fpm, so every PR was green; only the release workflow's own gate lacked it. A gate that is exercised solely at release time reports its own breakage solely at release time. Same step and cache key as build-check.yml, so the two jobs cannot drift again. build-debian-package keeps its own install — it runs later and independently.
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the
Install Ruby and FPMstep (plus its gem cache) to therelease-package-contractsjob inpublish-release.yml, matching the step thatbuild-check.yml'stest-bejob already has.Why
The release path has been broken since 2026-07-24 and nothing could show it.
Two of the contracts this job runs build a real
.deband inspect its payload:deb-reconciler-staging.test.sh(#194)deb-sourcemap-policy.test.sh(#288)The last successful release was v2026.7.2 on 2026-07-19 — five days before the
first of those arrived. The very next release dispatch
(run 32447963881)
died at the first gate:
It stayed invisible because
build-check.yml'stest-bejob runs the samecontract suite and does install fpm — so every PR was green. Only the release
workflow's own gate lacked it. A gate exercised solely at release time reports its
own breakage solely at release time.
Nothing was published by that failed run:
publish-federation,build-debian-package,build-ceraui-system,create-releaseanddispatch-apt-reindexall showskipped,so there is no tag, no GitHub release, and no R2 write to reconcile.
How to verify
bun run test:release-package-contractspasses locally (fpm present) and is thesuite that was failing on the runner.
build-check.yml's, so the two jobscannot drift apart again.
build-debian-packagekeeps its own fpm install — it runs later and independently;this does not remove or reroute it.
Run release/package contracts).Risks
Low, and scoped to CI. Adds ~40 s of gem install to one release job, cached after the
first run. No source, no packaging logic, and no release semantics change — the job's
own contract assertions are untouched.
publish-release.ymlis askip_workflowsentry in the root
ci-local.manifest.yaml("secrets/OIDC"), so no manifest leaf ordigest needs updating for this change.