Repository navigation
Conversation
We discussed this during the touch base with the information security team and decided to propose an ADR. NIST 800-171 requires us to keep some information private, and to salvage from having to make every IaC repo private we can split it out into two in a templated fashion.
|
LGTM. Whichever repo we choose, we should put the information in the private moc-compliance repo there. |
There was a problem hiding this comment.
I think this is a policy, not an ADR. The ADR would be a description of exactly how we have managed the split between public/private repositories, how we are handling things like permissions in CI jobs, how we are handling templating values, etc.
Or if this is an ADR, it should describe a more concrete implementation.
| - A change that touches a placeholder and its value needs coordinated pull requests in two repositories, and the two can drift apart. | ||
| - The EKS jobs need a read-only credential for the private repositories, which must be rotated at least every 90 days. | ||
| - The private repositories hold sensitive configuration, so access to them must be limited and reviewed. | ||
| - A real value committed to a public repository stays in its history. It must be treated as exposed and replaced. |
There was a problem hiding this comment.
I'm not sure I agree with this for the types of information we're talking about here. If we accidentally expose an ip address, we have to..."replace it"? These are not security credentials, and in our current environment addresses are almost exclusively assigned dynamically.
There was a problem hiding this comment.
Maybe we can grandfather in the existing IPs that have been documented? Once the private repo is up, you'd have to go out of your way to expose IPs in the public repo.
For the sake of the compliant environment though, I think this rotation is necessary.
| ### Changes | ||
|
|
||
| - A change that touches a placeholder and its value needs coordinated pull requests in two repositories, and the two can drift apart. | ||
| - The EKS jobs need a read-only credential for the private repositories, which must be rotated at least every 90 days. |
There was a problem hiding this comment.
This, at least, I think is a solved problem: we use github apps to acquire repository credentials in CI workflows, and those credentials are ephemeral: they existing only for the duration of the workflow.
There was a problem hiding this comment.
In this case we'd need a private key to sign the JWT that we're sending to GitHub, so we'd still need a credential that we rotate every 90 days. https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/managing-private-keys-for-github-apps
Most of this is also included in the SDLC policy that I just proposed. #50 so this may potentially be superseded by that. |
Do you want to close this one for now and resubmit later with more technical details? |
|
@knikolla please either close this as superceded or make requested changes/resolve them so we can proceed with either an ADR or Policy PR and approvals. |
We discussed this during the touch base with the information security team and decided to propose an ADR.
NIST 800-171 requires us to keep some information private, and to salvage from having to make every IaC repo private we can split it out into two in a templated fashion.