quickcheck!: accept mut bindings in property arguments - #354
Open
chiliec wants to merge 1 commit into
Open
Conversation
The macro matched each argument as `ident : ty`, so `fn prop(mut xs: Vec<u8>) -> bool` failed with "no rules expected the token `xs`". Match one or more idents before the colon and forward them verbatim into the generated `prop` fn. Fixes BurntSushi#269
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #269
The
quickcheck!macro matched each property argument as$arg_name:ident : $arg_ty:ty, so amutbinding likefn prop(mut xs: Vec<usize>) -> boolfailed withno rules expected the tokenxs``.Fix: match one or more idents before the colon (
$($arg_name:ident)+ : $arg_ty:ty) and forward them verbatim into the generatedpropfn. Plainident: tyarguments expand exactly as before; thefn(...)cast still uses only the types. (Apat_paramfragment isn't an option here —macro_rulesdoesn't allow:after it.)Tests: added
prop_macro_mut_arg(mut xs: Vec<usize>)to the existingquickcheck! { ... }block insrc/tests.rs.Validation (rustc 1.98.1, local):
cargo test --lib prop_macro→error: no rules expectedxs`` (reproduces the issue).cargo test→ 70 passed (lib) + 4 passed (quickcheck_macros), 0 failed.cargo fmt --checkclean.