Fix Swift adapter property assignment flow and initializer applicability - #249
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After restricting conversion summaries to resolved Foundation declarations, legitimate local conversion bodies lost their endpoint flow while a constant wrong-arity initializer still produced a false flow. This change repairs both behaviors in an explicitly versioned, non-scored adapter experiment.
Key Changes:
getNode().asAstNode()to the existinggetAst()relation, so property-getter values reach their SSA definition and initializer return. The correction is structural and contains no fixture identity or source/sink condition.Touch Points:
adapters/codeql/swift-resolved-native-v1/patches/evidence/swift-resolved-native-v1/scripts/*swift*conversion*andscripts/materialize-swift-resolved-pack-v3.pydocs/swift-conversion-body.md.github/workflows/ci.ymlValidation: body verifier and 13 tests; diagnostic verifier and 7 tests;
cargo fmt --check;git diff --check. Native extraction completed in 91.163 seconds, and all retained successful diagnostic queries stayed within 60-second / 2048-MiB requests. Aggregate memory compliance remains unproven. Fresh extraction and canonical summary controls remain required before family qualification; no scores, full-corpus completion, freeze or release is claimed.Refs #220 and #215. Both issues remain open; acceptance is incomplete.