Skip to content

Fix Swift adapter property assignment flow and initializer applicability - #249

Merged
DavidBakerEffendi merged 6 commits into
mainfrom
dave/swift-conversion-bodies-220
Sep 23, 2026
Merged

DavidBakerEffendi merged 6 commits into
mainfrom
dave/swift-conversion-bodies-220

Conversation

@DavidBakerEffendi

Copy link
Copy Markdown
Collaborator

After restricting conversion summaries to resolved Foundation declarations, legitimate local conversion bodies lost their endpoint flow while a constant wrong-arity initializer still produced a false flow. This change repairs both behaviors in an explicitly versioned, non-scored adapter experiment.

Key Changes:

  • Correct the isolated Swift library's SSA assignment RHS mapping from getNode().asAstNode() to the existing getAst() relation, so property-getter values reach their SSA definition and initializer return. The correction is structural and contains no fixture identity or source/sink condition.
  • Restrict the additional String data-initializer heuristic using resolved declaration identity. Combined with the SSA repair, the real roundtrip and transparent local-body chain flow; safe and constant cases do not. Retain stock, failed intermediate, and corrected evidence with preregistered plans, portable verification and mutation tests.

Touch Points:

  • adapters/codeql/swift-resolved-native-v1/patches/
  • evidence/swift-resolved-native-v1/
  • scripts/*swift*conversion* and scripts/materialize-swift-resolved-pack-v3.py
  • docs/swift-conversion-body.md
  • .github/workflows/ci.yml

Validation: body verifier and 13 tests; diagnostic verifier and 7 tests; cargo fmt --check; git diff --check. Native extraction completed in 91.163 seconds, and all retained successful diagnostic queries stayed within 60-second / 2048-MiB requests. Aggregate memory compliance remains unproven. Fresh extraction and canonical summary controls remain required before family qualification; no scores, full-corpus completion, freeze or release is claimed.

Refs #220 and #215. Both issues remain open; acceptance is incomplete.

@DavidBakerEffendi
DavidBakerEffendi merged commit eb335ef into main Sep 23, 2026
4 checks passed
@DavidBakerEffendi
DavidBakerEffendi deleted the dave/swift-conversion-bodies-220 branch September 23, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant