Fix Swift adapter append applicability and test resolved conversion summaries - #248
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pinned Swift taint heuristics produce a false flow for a constant-body append lookalike, and conversion summaries attach to local Data/String lookalikes. This change adds a separately versioned adapter experiment with retained controls and explicit incomplete qualification.
Key Changes:
Touch Points:
adapters/codeql/swift-resolved-native-v1/evidence/swift-resolved-native-v1/scripts/*swift-resolved*andscripts/run-swift-resolved-append-qualification.pydocs/swift-resolved-native.md.github/workflows/ci.ymlValidation: append verifier plus 8 tests; conversion verifier plus 7 tests;
cargo fmt --check;git diff --check. Native controls and all successful query phases stayed within their requested deadlines. Aggregate memory compliance and whole-profile semantic completeness remain unproven. The conversion experiment still needs independent initializer heuristic and ordinary-body controls. No full-corpus scoring, freeze, or release is claimed.Refs #220 and #215. Both issues remain open; acceptance is incomplete.