Skip to content

Fix Swift adapter append applicability and test resolved conversion summaries - #248

Merged
DavidBakerEffendi merged 7 commits into
mainfrom
dave/swift-resolved-models-220
Sep 23, 2026
Merged

DavidBakerEffendi merged 7 commits into
mainfrom
dave/swift-resolved-models-220

Conversation

@DavidBakerEffendi

Copy link
Copy Markdown
Collaborator

Pinned Swift taint heuristics produce a false flow for a constant-body append lookalike, and conversion summaries attach to local Data/String lookalikes. This change adds a separately versioned adapter experiment with retained controls and explicit incomplete qualification.

Key Changes:

  • Filter the append heuristic using resolved declaration identity, preserve ordinary method-body propagation, and retain unchanged canonical positive/negative runs. The positive flows and negative remains clean.
  • Materialize an isolated, hash-bound Swift library patch for four conversion selectors. Real summaries and flow remain; local summaries and the observed false flow are absent. Preserve both failed attempts and the corrected run, add portable verifiers and mutation tests, and keep all outcomes non-scored.

Touch Points:

  • adapters/codeql/swift-resolved-native-v1/
  • evidence/swift-resolved-native-v1/
  • scripts/*swift-resolved* and scripts/run-swift-resolved-append-qualification.py
  • docs/swift-resolved-native.md
  • .github/workflows/ci.yml

Validation: append verifier plus 8 tests; conversion verifier plus 7 tests; cargo fmt --check; git diff --check. Native controls and all successful query phases stayed within their requested deadlines. Aggregate memory compliance and whole-profile semantic completeness remain unproven. The conversion experiment still needs independent initializer heuristic and ordinary-body controls. No full-corpus scoring, freeze, or release is claimed.

Refs #220 and #215. Both issues remain open; acceptance is incomplete.

@DavidBakerEffendi
DavidBakerEffendi merged commit 4d48e91 into main Sep 23, 2026
4 checks passed
@DavidBakerEffendi
DavidBakerEffendi deleted the dave/swift-resolved-models-220 branch September 23, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant