Repository navigation
GAUD-10806: enable AA option and add playwright dependency - #1123
Merged
Merged
Conversation
dlockhart
marked this pull request as ready for review
October 21, 2026 14:34
|
🎉 This PR is included in version 1.55.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes here:
The first enables the
includeAApixelmatch option. This will include more anti-aliasing changes in the diffs. We suspect that not having this option enabled has been causing the majority of our "byte diff"s -- because the images are actually different so have different file sizes but pixelmatch was ignoring the diffs due to them being anti-aliasing related.The second change adds Playwright as an explicit dependency with the
~(patch only) version range. That will exclude it from ourupdate-package-lockjob and instead have us rely on Dependabot for version updates. That way when we merge those Dependabot PRs, we can manually trigger a release of the testing library. Otherwise we can get in a situation where many Chrome releases happen without a release of@brightspace-ui/testing.