Skip to content

GAUD-10637 - Add workflow permissions #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svanherk merged 2 commits into from
Sep 22, 2026
Merged

GAUD-10637 - Add workflow permissions #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a524293
GAUD-10637 - Add workflow permissions
svanherk Sep 21, 2026
88b6fb5
Fix tests
svanherk Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
name: CI
on: pull_request

permissions:
contents: read

jobs:
test:
timeout-minutes: 5
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ on:
push:
branches:
- main

permissions:
contents: read

jobs:
release:
name: Release
Expand Down
12 changes: 6 additions & 6 deletions test/d2l-localize-behavior.test.js
View file
Open in desktop

@svanherk svanherk Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outcome of BrightspaceUI/intl#378

Original file line number Diff line number Diff line change
Expand Up @@ -234,30 +234,30 @@ describe('d2l-localize-behavior', () => {

it('should format a time using default format', () => {
const val = elem.formatTime(date);
expect(val).to.equal('5:13 PM');
expect(val).to.equal('5:13 PM');
});

it('should format a time using specified format', () => {
const val = elem.formatTime(date, { format: 'full' });
expect(val).to.equal('5:13 PM ');
expect(val).to.equal('5:13 PM ');
});

it('should format time via data binding', () => {
expect(elem.$$('.time').innerText).to.equal('5:13 PM');
expect(elem.$$('.time').innerText).to.equal('5:13 PM');
});

it('should format a date/time using default format', () => {
const val = elem.formatDateTime(date);
expect(val).to.equal('12/1/2017 5:13 PM');
expect(val).to.equal('12/1/2017 5:13 PM');
});

it('should format a date/time using specified format', () => {
const val = elem.formatDateTime(date, { format: 'medium' });
expect(val).to.equal('Dec 1, 2017 5:13 PM');
expect(val).to.equal('Dec 1, 2017 5:13 PM');
});

it('should format a date/time using data binding', () => {
expect(elem.$$('.date-time').innerText).to.equal('12/1/2017 5:13 PM');
expect(elem.$$('.date-time').innerText).to.equal('12/1/2017 5:13 PM');
});

it('should parse a date', () => {
Expand Down
Loading