[feat] Skin main window via ElvUI when loaded#446
Open
bootinup wants to merge 1 commit into
Open
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Adds opt-in ElvUI skinning to the ECS main window. When ElvUI is loaded, the block calls into
E:GetModule(\"Skins\")to restyle the frame; when ElvUI is absent, the block is a no-op and ECS looks exactly as it does today.Specifically, in
Modules/Stats.luaafter the main frame is built:S:HandleFrame(mainFrame)— applies ElvUI's frame templateCloseButton,title(withE.media.normFont), andconfigButtonso they sit correctly inside the skinned frameS:HandleButtononconfigButtonandtoggleButtonS:HandleScrollBaronmainFrame.ScrollFrame.ScrollBarScrollFrameanchors so the content area lines up with the skinned borderThe whole block is guarded by
if ElvUI then ... if S then ... end end, so users without ElvUI (or with the Skins module disabled) are unaffected.Testing
I have not personally tested on Classic Era, Wrath Classic, or Retail, but the APIs used (
HandleFrame,HandleButton,HandleScrollBar) are present in all ElvUI variants and the code is not gated onWOW_PROJECT_ID, so it should behave the same anywhere ECS loads.Test plan