chore: remove legacy maintainer loop - #8
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Aligns the repo with the locally committed (previously unpushed) change by removing the legacy bram-maintainer-loop skill and routing all maintainer-orchestration references through bram-maintainer-loop-v2.
Changes:
- Removed the legacy
skills/bram-maintainer-loopskill (and its agent config) plus the associatedprompts/bram-maintainer-project-loop.md. - Repointed documentation and skill guidance that referenced
bram-maintainer-looptobram-maintainer-loop-v2. - Added a changelog entry documenting the removal and updated the flagged-repos config header accordingly.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| VISION.md | Updates vision wording to reference maintainer-loop v2 guardrails. |
| skills/to-prd/SKILL.md | Updates loop-mode guidance to point at bram-maintainer-loop-v2. |
| skills/to-issues/SKILL.md | Updates loop-mode guidance to point at bram-maintainer-loop-v2. |
| skills/tdd/SKILL.md | Updates loop-mode guidance to point at bram-maintainer-loop-v2. |
| skills/github-project-triage/SKILL.md | Updates autonomous-mode trigger text to refer to bram-maintainer-loop-v2. |
| skills/bram-maintainer-loop/SKILL.md | Removes the legacy current-repo maintainer loop skill. |
| skills/bram-maintainer-loop/agents/openai.yaml | Removes the legacy skill’s OpenAI agent interface metadata. |
| README.md | Updates references and “preserve” list to bram-maintainer-loop-v2. |
| prompts/bram-maintainer-project-loop.md | Removes legacy project-loop prompt that invoked the old loop. |
| config/bram-loop-repos.txt | Updates header comment to indicate v2 flagged repos. |
| CHANGELOG.md | Documents removal of the legacy loop and prompt. |
| AGENTS.MD | Updates upstream-sync preserve list to bram-maintainer-loop-v2. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
origin/mainin line with the localmaincheckout, which has been carrying this change unpushed.Why
b54218a1"chore: remove legacy maintainer loop" was committed locally but never reachedorigin/main. Because PRs #6 and #7 were squash-merged, git sees no shared history between the local commits and their squashed counterparts, so a plaingit pullcannot reconcile the two sides. Cherry-picking the one commit that is genuinely missing is the clean way to close the gap.After this lands,
origin/mainholds everything, and the local checkout can simply reset onto it.What changed
Removes the legacy current-repository
bram-maintainer-loopskill (412 lines) and itsprompts/bram-maintainer-project-loop.md, then repoints every$bram-maintainer-loopreference at$bram-maintainer-loop-v2acrossAGENTS.MD,README.md,VISION.md,config/bram-loop-repos.txt, and thegithub-project-triage,tdd,to-issues,to-prdskills. Maintainer orchestration now routes only through v2.Conflict resolutions
The cherry-pick hit four conflicts, all caused by PRs #6 and #7 having reshaped the same regions:
README.md— the original commit edited the hand-maintained Codex symlink list that feat: add sync-skills skill mirror #6 deleted in favour of thescripts/sync-skillssection. Kept the sync-skills version; the edited line is obsolete because the mirror is generated.skills/codex-first/SKILL.md— both sides rewrote the maintainer pointer line. Kept feat: adopt codex-huge-context, refresh codex-first #7's wording ("Whole-repo/multi-repo maintainer coordination"), which already said$bram-maintainer-loop-v2.AGENTS.MD— kept feat: add sync-skills skill mirror #6'sscripts/sync-skillsrule and took this commit's-v2rename in the upstream-sync preserve list.CHANGELOG.md— kept all four entries, newest first.Verification
scripts/validate-skillspasses at 41 skills, down from 42 exactly as expected withbram-maintainer-loopgone. No non-historical$bram-maintainer-loopreferences survive — the only remaining mentions are past changelog entries, which correctly describe what happened at the time.