feat(autoreview): replace vendored copy with canonical openclaw/agent-skills - #11
Merged
Conversation
…-skills Sync the complete skills/autoreview directory from openclaw/agent-skills at c4ab5e7f999cf504890986322473d3e7afd373af. Our vendored copy was a 2026-06-13 snapshot; the canonical helper is now 12,001 lines against our 2,485. Adds TruffleHog secret scanning over the reviewed diff, a Scope Governor (in-scope blocker / follow-up / stop-and-escalate), oversized-bundle handling, release-branch rules, Codex gpt-5.6-sol with access-only gpt-5.6-terra fallback, a 255-test hardening suite, and the skill-level AGENTS.md declaring openclaw/agent-skills canonical. Engines that cannot be fully isolated (droid, copilot, opencode, cursor) are refused rather than run. --preset is gone, so the AGENTS.MD rule for API work now uses --engine claude --model claude-opus-4-8. TruffleHog is a hard requirement: the helper exits early when it is missing.
There was a problem hiding this comment.
Pull request overview
Syncs this repo’s autoreview skill to the canonical openclaw/agent-skills implementation (commit c4ab5e7…), primarily to pick up significant security hardening (TruffleHog-based secret scanning + isolation/refusal rules) and the expanded test suite/fixtures.
Changes:
- Replace/update the
autoreviewskill docs and implementation, including engine policy (refuse non-isolatable engines) and new TruffleHog preflight scanning. - Add/expand test coverage (hardening suite, harness updates) plus TS fixtures used to validate secret-detection behavior.
- Update repo-level guidance (
AGENTS.MD) and changelog to reflect the--presetremoval and new recommended CLI flags.
Reviewed changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| skills/autoreview/SKILL.md | Updates the skill contract/docs (scope governor, isolation rules, TruffleHog requirement, CLI flag changes). |
| skills/autoreview/AGENTS.md | Declares openclaw/agent-skills as canonical source and forbids downstream behavior variants. |
| skills/autoreview/scripts/autoreview | Canonical helper implementation (bundle building, isolation, TruffleHog preflight, engine orchestration). |
| skills/autoreview/scripts/autoreview_test.py | Adds unit tests for critical parsing/isolation/compat behaviors. |
| skills/autoreview/scripts/test-review-harness.py | Updates harness engines/defaults and validates prompt scope policy presence. |
| skills/autoreview/scripts/test-review-harness.ps1 | Aligns PowerShell harness engine set with the new supported engines. |
| skills/autoreview/tests/test_autoreview_hardening.py | Adds/updates hardening regression tests for isolation and credential handling. |
| skills/autoreview/tests/fixtures/typescript-sensitive-literals.ts | Adds sensitive-literal corpus fixture for secret detection. |
| skills/autoreview/tests/fixtures/typescript-benign-references.ts | Adds benign “credential plumbing” fixture to avoid false positives. |
| skills/autoreview/tests/fixtures/typescript-benign-config-path-references.ts | Adds benign config-path fixture to ensure path strings are preserved. |
| CHANGELOG.md | Documents the canonical autoreview sync and major behavior/security changes. |
| AGENTS.MD | Updates API-work guidance to the new --engine/--model flags (no --preset). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+5092
to
+5095
| java = shutil.which("java") | ||
| if java is None: | ||
| self.skipTest("java is not installed") | ||
| with tempfile.TemporaryDirectory() as tempdir: |
Comment on lines
+5144
to
+5146
| java = shutil.which("java") | ||
| if java is None: | ||
| self.skipTest("java is not installed") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the vendored
autoreviewskill with the canonical copy from openclaw/agent-skills atc4ab5e7f999cf504890986322473d3e7afd373af.Why
Our copy was a 2026-06-13 snapshot taken after steipete extracted the skill out of
agent-scripts(upstream'sskills/autoreviewhas been a symlink to a repo we couldn't see since 2026-05-24). The canonical version has moved a long way since — most of it security work.autoreview_test.py, TypeScript fixturesWhat we gain
trufflehog|secret_scan|redact; the canonical one has 71. Before any engine invocation it snapshots the exact added/modified content under review and scans it. Recent upstream commits are almost entirely this subsystem: replacing heuristics with TruffleHog (#145), scanning deleted credentials (#148), snapshot path-traversal hardening (#150), force-staging scan snapshots (#151), safe URI userinfo (#146).gpt-5.6-solwith an access-only fallback togpt-5.6-terra.AGENTS.md(plusCLAUDE.mdsymlink) declaringopenclaw/agent-skillscanonical and forbidding repo-local behavior variants — future syncs should copy the whole directory rather than patch ours.Behavior changes to be aware of
droid,copilot,opencode,cursor. Our copy still ran copilot and opencode; that permissiveness predates a deliberate hardening decision upstream.--presetno longer exists.AGENTS.MDtold agents to run$autoreview --preset claude-opusfor API work; that line now reads--engine claude --model claude-opus-4-8, which is the equivalent under the new flag set.run_trufflehog_preflightraisesSystemExitwhen the binary is missing. See the blocker below.Verification
python3 -m py_compileclean on bothscripts/autoreviewandscripts/autoreview_test.py.scripts/autoreview_test.py: 31 tests, all pass.tests/test_autoreview_hardening.py: 255 tests, 251 pass, 1 skipped, 4 fail — all four failures areUnable to locate a Java Runtimeon this machine (JVM-isolation tests). Environmental, not a port defect.scripts/validate-skillspasses.CLAUDE.md -> AGENTS.mdsymlink survived the copy.Blocker before this is usable
TruffleHog is not installed on this Mac, and
AGENTS.MDrequires$autoreviewbefore every commit/land — so merging this without installing it breaks the pre-land gate for every repo.