Repository navigation
Recover stranded prediction PRs: worker_prediction + worker_ml producer - #235
Merged
Merged
Conversation
added 2 commits
October 9, 2026 01:00
New base + project that consumes predictions.to_insert and inserts into the prediction and prediction_latest tables via WorkerRunner (modeled on worker_report) (#228). - PredictionRepo/PredictionLatestRepo insert signatures widened to Sequence (covariant, type-level only) - project scaffolding: pyproject.toml, Dockerfile, uv.lock (mirrors worker_report)
Replaces the inline database insert with a produce to the new predictions.to_insert topic, decoupling the predictor from the db (#228). - worker_ml loses its database dependency (asyncmy, cryptography, sqlalchemy removed from the project) - on publish failure the source batch is requeued, offsets commit only after the produce succeeds - metrics: worker_ml_predictions_inserted -> worker_ml_predictions_published
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #228 (finally)
What happened
#231 and #230 were stacked PRs targeting
ml/predictions-topic-struct. That base branch still existed after #229 merged, so GitHub never retargeted them to develop — and both were merged into the side branch (dbd0c2c,2364f4c), never into develop.Result: develop got the topic (#229), firehose exposure (#232) and the CI workflow (#234) — but none of the actual worker code. The dispatched
worker_predictionrun failed withcd: can't cd to projects/worker_prediction.This PR
Cherry-picks the two stranded commits onto develop, unchanged:
325b216feat(worker_prediction): consumer base + project inserting predictions from Kafka (from Add worker_prediction: consume predictions.to_insert into MySQL #231)1314849feat(worker_ml): publish predictions to Kafka instead of MySQL insert (from worker_ml: publish predictions to Kafka instead of MySQL insert #230)Verification
uv lock --lockedinprojects/worker_predictionpasses (the exact failing CI step)