Chore: Refactoring & Cleanup

[BornToBeRoot]

No description provided.

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR performs broad refactoring/cleanup across many view models (switching to auto-properties with backing field) and introduces a new Firewall settings view, wiring it into settings/profile view registries and app upgrade logic.

Changes:

• Added Firewall settings view + view model and integrated it into settings navigation and localization strings.
• Refactored many view models to use auto-properties (removing explicit backing fields).
• Updated settings/profile view managers and upgrade logic to include the Firewall application.

Reviewed changes

Copilot reviewed 98 out of 115 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
Source/NETworkManager/Views/FirewallSettingsView.xaml.cs	Adds code-behind that instantiates and binds a Firewall settings VM.
Source/NETworkManager/Views/FirewallSettingsView.xaml	Adds a basic Firewall settings UserControl UI with localized header.
Source/NETworkManager/ViewModels/WiFiConnectViewModel.cs	Replaces many backing fields with auto-properties + field usage and initializers.
Source/NETworkManager/ViewModels/WhoisViewModel.cs	Refactors properties to auto-properties with field.
Source/NETworkManager/ViewModels/WhoisHostViewModel.cs	Refactors properties and updates tab close casting to IDragablzTabItem.
Source/NETworkManager/ViewModels/WelcomeViewModel.cs	Refactors boolean settings properties to auto-properties with initializers.
Source/NETworkManager/ViewModels/WebConsoleSettingsViewModel.cs	Refactors settings properties to auto-properties with field.
Source/NETworkManager/ViewModels/WebConsoleHostViewModel.cs	Refactors properties and updates tab close casting to IDragablzTabItem.
Source/NETworkManager/ViewModels/WebConsoleConnectViewModel.cs	Refactors Url to auto-property with field.
Source/NETworkManager/ViewModels/WakeOnLANSettingsViewModel.cs	Refactors DefaultPort to auto-property with field.
Source/NETworkManager/ViewModels/TracerouteViewModel.cs	Refactors a large set of properties to auto-properties, adds initializers for collections.
Source/NETworkManager/ViewModels/TracerouteSettingsViewModel.cs	Refactors traceroute settings properties to auto-properties.
Source/NETworkManager/ViewModels/TracerouteHostViewModel.cs	Refactors properties and updates tab close casting to IDragablzTabItem.
Source/NETworkManager/ViewModels/TigerVNCSettingsViewModel.cs	Refactors settings properties to auto-properties with field.
Source/NETworkManager/ViewModels/TigerVNCHostViewModel.cs	Refactors properties and updates tab close casting to IDragablzTabItem.
Source/NETworkManager/ViewModels/TigerVNCConnectViewModel.cs	Refactors Host/Port to auto-properties with field.
Source/NETworkManager/ViewModels/SubnetCalculatorWideSubnetViewModel.cs	Refactors properties to auto-properties with field.
Source/NETworkManager/ViewModels/SubnetCalculatorSubnettingViewModel.cs	Refactors properties and initializes collections inline.
Source/NETworkManager/ViewModels/SubnetCalculatorCalculatorViewModel.cs	Refactors properties to auto-properties with field.
Source/NETworkManager/ViewModels/SettingsWindowViewModel.cs	Refactors window settings properties to auto-properties with field.
Source/NETworkManager/ViewModels/SettingsViewModel.cs	Adds a cached Firewall settings view and routing in ChangeSettingsContent.
Source/NETworkManager/ViewModels/SettingsUpdateViewModel.cs	Refactors update settings properties to auto-properties with field.
Source/NETworkManager/ViewModels/SettingsStatusViewModel.cs	Refactors status settings properties to auto-properties with field.
Source/NETworkManager/ViewModels/SettingsSettingsViewModel.cs	Refactors settings-location related properties to auto-properties and wraps a long line.
Source/NETworkManager/ViewModels/SettingsProfilesViewModel.cs	Refactors profiles-location related properties to auto-properties and wraps a long line.
Source/NETworkManager/ViewModels/SettingsNetworkViewModel.cs	Refactors network settings properties to auto-properties.
Source/NETworkManager/ViewModels/SettingsLanguageViewModel.cs	Refactors selection/search properties to auto-properties.
Source/NETworkManager/ViewModels/SettingsHotKeysViewModel.cs	Refactors hotkey properties to auto-properties.
Source/NETworkManager/ViewModels/SettingsGeneralViewModel.cs	Refactors general app settings properties to auto-properties.
Source/NETworkManager/ViewModels/SettingsAutostartViewModel.cs	Refactors autostart properties to auto-properties.
Source/NETworkManager/ViewModels/SettingsAppearanceViewModel.cs	Refactors appearance settings properties to auto-properties.
Source/NETworkManager/ViewModels/ServerConnectionInfoProfileViewModel.cs	Refactors profile properties and initializes selections inline.
Source/NETworkManager/ViewModels/SNTPLookupViewModel.cs	Refactors properties to auto-properties and initializes collections inline.
Source/NETworkManager/ViewModels/SNTPLookupSettingsViewModel.cs	Refactors properties to auto-properties and initializes defaults inline.
Source/NETworkManager/ViewModels/SNTPLookupHostViewModel.cs	Refactors host properties and updates tab close casting to IDragablzTabItem.
Source/NETworkManager/ViewModels/SNMPSettingsViewModel.cs	Refactors SNMP settings properties to auto-properties and initializes defaults inline.
Source/NETworkManager/ViewModels/SNMPOIDProfilesViewModel.cs	Refactors selection/search properties to auto-properties.
Source/NETworkManager/ViewModels/SNMPOIDProfileViewModel.cs	Refactors editable fields to auto-properties with field.
Source/NETworkManager/ViewModels/SNMPHostViewModel.cs	Refactors host VM properties and updates tab close casting to IDragablzTabItem.
Source/NETworkManager/ViewModels/RemoteDesktopHostViewModel.cs	Refactors host VM properties and updates tab close casting to IDragablzTabItem.
Source/NETworkManager/ViewModels/RemoteDesktopConnectViewModel.cs	Refactors connection properties to auto-properties; initializes secure-string + flags inline.
Source/NETworkManager/ViewModels/PuTTYHostViewModel.cs	Refactors host VM properties and updates tab close casting to IDragablzTabItem.
Source/NETworkManager/ViewModels/PuTTYConnectViewModel.cs	Refactors many connection properties to auto-properties with field.
Source/NETworkManager/ViewModels/ProfilesViewModel.cs	Refactors properties to auto-properties and reformats a conditional expression.
Source/NETworkManager/ViewModels/ProfileFileViewModel.cs	Refactors Name and IsEdit to auto-properties.
Source/NETworkManager/ViewModels/PowerShellSettingsViewModel.cs	Refactors settings properties; initializes ExecutionPolicies inline.
Source/NETworkManager/ViewModels/PowerShellHostViewModel.cs	Refactors host VM properties and updates tab close casting to IDragablzTabItem.
Source/NETworkManager/ViewModels/PowerShellConnectViewModel.cs	Refactors connect VM properties; initializes ExecutionPolicies inline.
Source/NETworkManager/ViewModels/PortScannerViewModel.cs	Refactors scanner properties; initializes results/selection collections inline.
Source/NETworkManager/ViewModels/PortScannerSettingsViewModel.cs	Refactors settings properties; initializes default selection inline.
Source/NETworkManager/ViewModels/PortScannerHostViewModel.cs	Refactors host VM properties and updates tab close casting to IDragablzTabItem.
Source/NETworkManager/ViewModels/PortProfilesViewModel.cs	Refactors selection/search properties; reformats ArrayList initializer.
Source/NETworkManager/ViewModels/PortProfileViewModel.cs	Refactors editable profile fields to auto-properties with field.
Source/NETworkManager/ViewModels/PingMonitorViewModel.cs	Refactors many monitor properties to auto-properties with field.
Source/NETworkManager/ViewModels/PingMonitorSettingsViewModel.cs	Refactors settings properties to auto-properties.
Source/NETworkManager/ViewModels/MessageViewModel.cs	Refactors init-only properties to auto-properties with field.
Source/NETworkManager/ViewModels/MessageConfirmationViewModel.cs	Refactors init-only properties to auto-properties with field.
Source/NETworkManager/ViewModels/LookupPortViewModel.cs	Refactors lookup state/results properties; initializes collections inline.
Source/NETworkManager/ViewModels/LookupOUILookupViewModel.cs	Refactors lookup state/results properties; initializes collections inline.
Source/NETworkManager/ViewModels/ListenersViewModel.cs	Refactors search/results/selection/status properties; initializes collections inline.
Source/NETworkManager/ViewModels/IPScannerViewModel.cs	Refactors scanner properties; initializes results/selection collections inline.
Source/NETworkManager/ViewModels/IPGeolocationViewModel.cs	Refactors query/status properties to auto-properties.
Source/NETworkManager/ViewModels/IPApiIPGeolocationWidgetViewModel.cs	Refactors widget properties to auto-properties.
Source/NETworkManager/ViewModels/IPApiDNSResolverWidgetViewModel.cs	Refactors widget properties to auto-properties.
Source/NETworkManager/ViewModels/IPAddressViewModel.cs	Refactors base IP address property to auto-property with field.
Source/NETworkManager/ViewModels/IPAddressAndSubnetmaskViewModel.cs	Refactors address/subnetmask properties to auto-properties.
Source/NETworkManager/ViewModels/HostsFileEditorViewModel.cs	Refactors editor properties; initializes results/selection collections inline.
Source/NETworkManager/ViewModels/HostsFileEditorEntryViewModel.cs	Refactors entry properties to auto-properties.
Source/NETworkManager/ViewModels/FirewallSettingsViewModel.cs	Adds initial Firewall settings VM skeleton with (currently empty) loading method.
Source/NETworkManager/ViewModels/ExportViewModel.cs	Refactors export options to auto-properties; initializes ExportAll default inline.
Source/NETworkManager/ViewModels/DropdownViewModel.cs	Refactors init-only dropdown properties to auto-properties with field.
Source/NETworkManager/ViewModels/DiscoveryProtocolViewModel.cs	Refactors discovery settings/state properties; initializes defaults inline.
Source/NETworkManager/ViewModels/DNSLookupSettingsViewModel.cs	Refactors DNS lookup settings; simplifies query-class enumeration code.
Source/NETworkManager/ViewModels/BitCalculatorViewModel.cs	Refactors calculator properties; initializes Units and Result inline.
Source/NETworkManager/StatusWindow.xaml.cs	Refactors backing fields to auto-properties with field.
Source/NETworkManager.Settings/SettingsViewManager.cs	Adds docs, switches to collection expressions, and adds Firewall settings entry.
Source/NETworkManager.Settings/SettingsManager.cs	Adds upgrade logic intended to insert Firewall into application list.
Source/NETworkManager.Profiles/ProfileViewManager.cs	Adds docs, switches to collection expressions, and adds Firewall profile entry.
Source/NETworkManager.Profiles/ProfileName.cs	Adds Firewall profile enum value (minor formatting change).
Source/NETworkManager.Profiles/ProfileInfo.cs	Adds Firewall_Enabled to profile copy + schema (plus commented placeholders).
Source/NETworkManager.Localization/Resources/Strings.resx	Adds Firewall-related localization strings.
Source/GlobalAssemblyInfo.cs	Bumps assembly version to 2026.3.10.0.
CLAUDE.md	Adds pointer to AGENTS.md guidelines.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.