Skip to content

Fix split-pane pageXof/pageYof crash on 0-coordinate / native event (BL-16584) #8084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hatton wants to merge 2 commits into
base: master
Choose a base branch
from
+12 −2
Draft

Fix split-pane pageXof/pageYof crash on 0-coordinate / native event (BL-16584) #8084

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc1c517
Fix split-pane pageXof/pageYof crash on 0-coordinate / native event (…
hatton Jul 20, 2026
e61bc0e
Merge origin/master into BL-16584-sentry-splitpane-pagexy
hatton Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/BloomBrowserUI/lib/split-pane/split-pane.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -949,12 +949,22 @@ export function splitPane($splitPanes: JQuery): void {
return [snapped, dividerPositionForDisplay(snapped, true) + "%", false];
}

// event.pageX/pageY can legitimately be 0 (dragging to the very edge), so check for
// null/undefined rather than falsiness — otherwise a 0 wrongly falls through. And
// event.originalEvent is undefined for a native (non-jQuery) event, so guard it before
// dereferencing instead of crashing the drag (Sentry BLOOM-DESKTOP-FPW/FJ0/DTS).
function pageXof(event) {
return event.pageX || event.originalEvent.pageX;
if (event.pageX != null) return event.pageX;
if (event.originalEvent && event.originalEvent.pageX != null)
return event.originalEvent.pageX;
return 0;
}

function pageYof(event) {
return event.pageY || event.originalEvent.pageY;
if (event.pageY != null) return event.pageY;
if (event.originalEvent && event.originalEvent.pageY != null)
return event.originalEvent.pageY;
return 0;
}

function minHeight(element) {
Expand Down