Require to use CanonSourceFile in the CompiledProgram and TemplateProgram in new_with_dep method#315
Merged
apoelstra merged 1 commit intoMay 21, 2026
Conversation
Sdoba16
force-pushed
the
require-CanonSourceFile
branch
from
20266d2 to
ed7442c
Compare
…rogram to forbid passing SourceFile::anonymous
Sdoba16
force-pushed
the
require-CanonSourceFile
branch
from
ed7442c to
cdaab4d
Compare
Collaborator
|
ACK cdaab4d; tested locally |
LesterEvSe
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #311
Oblige user to use
CanonSourceFilein theCompiledProgramandTemplatePrograminnew_with_depmethod to prevent passingSourceFile::anonymous.This PR should be merged after the #312 to prevent conflicts as it follows its implementation.