-
Notifications
You must be signed in to change notification settings - Fork 629
Fix OpenClaw model picker sync #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
37c7509
fix: sync OpenClaw model picker on install
0xCheetah1 00f0af4
fix: guard postinstall script lookup
0xCheetah1 6757e08
fix: keep OpenClaw bundle patch non-fatal
0xCheetah1 c209439
fix: preserve OpenClaw plugin allowlist on update
0xCheetah1 86091aa
Revert "fix: preserve OpenClaw plugin allowlist on update"
0xCheetah1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| #!/usr/bin/env node | ||
|
|
||
| import { existsSync } from "node:fs"; | ||
| import { dirname, resolve } from "node:path"; | ||
| import { fileURLToPath } from "node:url"; | ||
| import { spawnSync } from "node:child_process"; | ||
|
|
||
| if (process.env.BLOCKRUN_CLAWROUTER_SKIP_POSTINSTALL === "1") { | ||
| process.exit(0); | ||
| } | ||
|
|
||
| const root = resolve(dirname(fileURLToPath(import.meta.url)), ".."); | ||
| const cliPath = resolve(root, "dist", "cli.js"); | ||
|
|
||
| if (!existsSync(cliPath)) { | ||
| process.exit(0); | ||
| } | ||
|
|
||
| const result = spawnSync(process.execPath, [cliPath, "setup"], { | ||
| stdio: "inherit", | ||
| env: { | ||
| ...process.env, | ||
| BLOCKRUN_CLAWROUTER_SKIP_POSTINSTALL: "1", | ||
| }, | ||
| }); | ||
|
|
||
| if (result.status && result.status !== 0) { | ||
| console.warn("[ClawRouter] OpenClaw setup did not complete; run `clawrouter setup` manually."); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
No timeout on synchronous child-process calls in the auto-triggered postinstall chain.
scripts/postinstall.mjsruns on everynpm installof this package and synchronously spawnscli.js setup, which itself shells out multiple times viaexecSync. None of these calls set atimeout, so a hang anywhere in this chain (corporate proxy, broken PATH lookup, stallednpm root -g) blocks the consumer'snpm installindefinitely.src/cli.ts#L556-L586: add atimeout(andkillSignal) option to theexecSync("command -v openclaw", ...)andexecSync("npm root -g", ...)calls used for OpenClaw path detection.scripts/postinstall.mjs#L19-L29: add atimeoutoption to thespawnSynccall as the outermost guard so a hang insidecli.js setupcan't blocknpm installindefinitely, and also checkresult.signal/result.error(not justresult.status) so a killed/crashed child process isn't silently treated as success.📍 Affects 2 files
src/cli.ts#L556-L586(this comment)scripts/postinstall.mjs#L19-L29🤖 Prompt for AI Agents