Skip to content

Fall back to software when hardware decoder open fails #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Blackspirits wants to merge 2 commits into
base: upl/review-base-c77c
Choose a base branch
from
Draft

Fall back to software when hardware decoder open fails #96

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be6a1e3
FFmpeg: fall back when hardware decoder open fails
Blackspirits Sep 13, 2026
3c6c0b1
FFmpeg: try remaining hardware decoders before software
Blackspirits Sep 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/ui/Logic/VideoPlayers/Ffmpeg/FfmpegPlayer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1162,7 +1162,7 @@ private static bool SupportsHardwareDevice(AVCodec* decoder, AVHWDeviceType devi
/// is attached; the caller can tell by <c>hw_device_ctx</c> being set. Any hardware setup
/// failure silently means software.
/// </summary>
private AVCodecContext* OpenDecoder(AVStream* stream, bool hardware = false)
private AVCodecContext* OpenDecoder(AVStream* stream, bool hardware = false, int hardwareStartIndex = 0)
{
var decoder = ffmpeg.avcodec_find_decoder(stream->codecpar->codec_id);
if (decoder == null)
Expand All @@ -1186,10 +1186,12 @@ private static bool SupportsHardwareDevice(AVCodec* decoder, AVHWDeviceType devi
codec->pkt_timebase = stream->time_base;
codec->thread_count = 0; // auto

var selectedHardwareIndex = -1;
if (hardware && stream->codecpar->codec_type == AVMediaType.AVMEDIA_TYPE_VIDEO)
{
foreach (var deviceType in HardwareDeviceTypes)
for (var i = hardwareStartIndex; i < HardwareDeviceTypes.Length; i++)
{
var deviceType = HardwareDeviceTypes[i];
if (!SupportsHardwareDevice(decoder, deviceType))
{
continue;
Expand All @@ -1212,13 +1214,22 @@ private static bool SupportsHardwareDevice(AVCodec* decoder, AVHWDeviceType devi

codec->hw_device_ctx = device; // freed with the codec context
codec->get_format = GetHardwareFormatDelegate;
selectedHardwareIndex = i;
break;
}
}

result = ffmpeg.avcodec_open2(codec, decoder, null);
if (result < 0)
{
if (hardware && selectedHardwareIndex >= 0)
{
var deviceName = HardwareDeviceName(codec);
Se.LogError($"ffmpeg player: {deviceName} decoder open failed for {ffmpeg.avcodec_get_name(stream->codecpar->codec_id)} ({FfmpegLibraries.ErrorText(result)}), trying the next hardware decoder or software");
ffmpeg.avcodec_free_context(&codec);
return OpenDecoder(stream, hardware: true, hardwareStartIndex: selectedHardwareIndex + 1);
}

ffmpeg.avcodec_free_context(&codec);
throw new InvalidOperationException($"avcodec_open2: {FfmpegLibraries.ErrorText(result)}");
}
Expand Down
Loading