Skip to content

Release detached seek frame when the FFmpeg video loop exits #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Blackspirits wants to merge 2 commits into from
Closed

Release detached seek frame when the FFmpeg video loop exits #91

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54b05c6
FFmpeg: release detached seek frame on video-loop exit
Blackspirits Sep 13, 2026
e040cfa
Fix video-loop local declaration
Blackspirits Sep 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/ui/Logic/VideoPlayers/Ffmpeg/FfmpegPlayer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -801,6 +801,7 @@ private void VideoLoop()
var swsSourceFormat = AVPixelFormat.AV_PIX_FMT_NONE;
var outputWidth = 0;
var outputHeight = 0;
VideoFrame? lastDropped = null; // detached from the queue while seeking; must be returned on every exit

try
{
Expand All @@ -818,7 +819,6 @@ private void VideoLoop()
var serial = -1;
var dropUntil = -1.0;
var presentedForSerial = false;
VideoFrame? lastDropped = null; // kept so a target past the last picture still shows something

while (!_closing)
{
Expand Down Expand Up @@ -988,6 +988,8 @@ private void VideoLoop()
}
finally
{
_videoFrames.Return(lastDropped);

if (sws != null)
{
ffmpeg.sws_freeContext(sws);
Expand Down
Loading