Make structural accessibility-sweep skips explicit - #89
Draft
Blackspirits wants to merge 2 commits into
Draft
Blackspirits wants to merge 2 commits into
Blackspirits wants to merge 2 commits into
Conversation
Blackspirits
commented
Sep 13, 2026
Blackspirits
left a comment
Owner
Author
There was a problem hiding this comment.
Independent adversarial re-check: the zero-skip probe deterministically exposed only FullScreenVideoWindow and MessageBox on both the initial run and retry. Both are structurally outside the DI/view-model sweep contract, and the final revision names only those two exclusions while preserving skipped.Count == 0 for every undeclared future skip. Full CI #34772761754 passed restore, build and the complete suite on the first run; UITests reported 5,149 passed, 9 skipped and 0 failed. Retry was not used. No blocker identified. Keep draft; no merge performed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The accessibility sweep previously allowed any window to disappear from coverage when it lacked a single-argument constructor or its constructor dependency was not registered in DI. The only aggregate guard was
opened > 50, so future windows could silently become untested.The audit probe made all structural skips fail and exposed exactly two deterministic exclusions on both the initial run and retry:
FullScreenVideoWindow: a runtime-only fullscreen host that requires an existingVideoPlayerControl, media state and callbacks; it is not a DI/view-model tool window;MessageBox: a factory-created modal with a private multi-argument constructor, exercised throughMessageBox.Showrather than DI construction.This revision:
SkippedWindowswith reasons;skipped.Count == 0after explicit exclusions;Validation
40c97b2def70f1c7b919602fbf4e7bed7d0c9fd3FullScreenVideoWindowandMessageBoxAI assistance: ChatGPT was used to audit fail-open structural coverage, classify the two existing exclusions, and convert implicit skipping into an explicit allowlist contract.