Stop suppressing accessibility-test dispatcher failures - #85
Blackspirits wants to merge 2 commits into
Conversation
Blackspirits
left a comment
There was a problem hiding this comment.
Independent adversarial re-check: upstream 6840e79 fixes the only documented closed-owner race at the production source, so retaining any dispatcher exception suppression in the accessibility sweep is no longer justified. The final diff only removes that suppression and updates its rationale. Full CI run #34767627147 passed restore, build and the complete solution test suite on the first run; UITests reported 5,149 passed, 9 skipped, 0 failed. Retry was not used. No blocker identified. Keep draft; no merge or upstream change performed.
Blackspirits
left a comment
There was a problem hiding this comment.
Independent adversarial re-check: upstream 6840e79 fixes the only documented closed-owner race at the production source, so retaining any dispatcher exception suppression in the accessibility sweep is no longer justified. The final diff only removes that suppression and updates its rationale. Full CI run #34767627147 passed restore, build and the complete solution test suite on the first run; UITests reported 5,149 passed, 9 skipped, 0 failed. Retry was not used. No blocker identified. Keep draft; no merge or upstream change performed.
Summary
The accessibility sweep still wraps
Dispatcher.UIThread.RunJobs()in a blanketcatch (Exception). That suppression was added for one known Video OCR race: its background media probe could post a message box after the test had already closed the window.Upstream commit
6840e797ae5b265a457e5086108f7d93ae45c85fnow fixes that race at the source by returning when the Video OCR window is already closing. Keeping the blanket catch after that fix only hides unrelated asynchronous failures.This change:
Validation
40c97b2def70f1c7b919602fbf4e7bed7d0c9fd3VideoOcrViewModel.OnLoadedtests/UI/Logic/AccessibleNamesTests.csNo production behavior is changed.
This supersedes the narrower approach in draft PR #82 if validation remains green.
AI assistance: ChatGPT was used to re-audit the accessibility test harness after the upstream Video OCR race fix and remove now-unnecessary exception suppression.