Fail the accessibility sweep when a window cannot open - #83
Draft
Blackspirits wants to merge 1 commit into
Draft
Blackspirits wants to merge 1 commit into
Blackspirits wants to merge 1 commit into
Conversation
Blackspirits
commented
Sep 13, 2026
Blackspirits
left a comment
Owner
Author
There was a problem hiding this comment.
Independent adversarial re-check: the change is test-only and converts runtime window-open exceptions from silent skips into explicit failures while preserving structural skips. Full CI run #34762328881 passed restore, build and the complete solution suite on the first run; UITests reported 5,150 passed, 9 skipped and 0 failed. This also confirms the stricter setup-failure gate is compatible with the current baseline. No blocker identified. Keep draft; no merge or upstream change performed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The new accessibility sweep opens every DI-resolvable tool window and checks its visible inputs, but any exception raised while constructing/showing a window is currently added to the generic
skippedlist and the test continues. The only coverage floor isopened > 50.That means a real regression that makes one or many previously covered windows fail during setup can silently remove those windows from the accessibility sweep instead of failing it.
This change:
Validation
45f7430aa7ec8d32f0079563f12ff7c0bfd1dc8eSkippedWindowsis currently empty, so runtime setup failures are not declared expected exclusionstests/UI/Logic/AccessibleNamesTests.csBecause the stricter test remains green, the old exception-to-skip path was not required by the current baseline.
No production behavior is changed.
AI assistance: ChatGPT was used to adversarially review the accessibility test harness for fail-open coverage gaps.