Make TTS voice renames rollback-safe - #81
Draft
Blackspirits wants to merge 3 commits into
Draft
Blackspirits wants to merge 3 commits into
Blackspirits wants to merge 3 commits into
Conversation
Blackspirits
commented
Sep 13, 2026
Blackspirits
left a comment
Owner
Author
There was a problem hiding this comment.
Independent adversarial re-check: the final diff remains limited to the rename helper and focused regression tests. Source files are staged before destination checks, no destination uses overwrite semantics, partial staging/publishing paths attempt reverse-order rollback, case-only renames are handled without destroying a distinct case-sensitive target, and cache cleanup is intentionally best-effort after the rename transaction. Full CI run #34760867384 passed restore/build/full tests on the first run with no retry. No blocker identified. Keep draft; no merge/promotion performed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The new TTS Voice Manager renames a file-backed clone by moving its sidecars first and its WAV last. Two failure modes can corrupt or destroy voice data:
overwrite:true, so renamingCaseVoicetocaseVoicecan overwrite an existing distinct voice;This change:
errorreturn contractRegression coverage
Validation
VoiceFileRename.csandVoiceFileRenameTests.cs9c0f6bdd77bc12bafff66f748b97c8b3d3a2d5b7; the intervening commits only updateTurkish.jsonand do not touch the TTS Voice Manager rename pathBase is upstream
4771a22765acdbdf5bd5b8a1c02f378c15e73ac9.AI assistance: ChatGPT was used to adversarially review the newly introduced Voice Manager file-rename flow, identify cross-platform overwrite and partial-move failure modes, design rollback-safe staging, and add focused regressions.