Port FixType filtering to current Fix common errors UI - #108
Draft
Blackspirits wants to merge 1 commit into
Draft
Conversation
Blackspirits
force-pushed
the
feature/fixtype-filter-c77c
branch
from
September 13, 2026 22:51
5f9b0c3 to
b56908f
Compare
Blackspirits
commented
Sep 13, 2026
Blackspirits
left a comment
Owner
Author
There was a problem hiding this comment.
Final independent re-check: this branch is now exactly one top commit on the final #107 HEAD. The stale author's branch would have reverted the current analyzing timing test hooks and two UiUtil.ScaledFontSize calls; both newer behaviors are preserved. Save/apply use AllFixRules, while Select all/Invert intentionally act only on visible filtered rows. The focused suite also pins FixDoubleGreaterThan to Dialog. Full CI #34788005507 passed restore, build and the complete solution suite on the first run; UITests reported 5,168 passed, 9 skipped and 0 failed. Retry was not used. No blocker identified. Keep draft; no merge performed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Current-base audit/port of the top commit from upstream stack PR SubtitleEdit#14443, layered on draft #107.
This PR adds only the UI consumer of the
FixTypecontract:Rebase integrity
The original top commit was based on a September 2 tree. Two later upstream improvements were present in current main but absent from the author's old branch:
AnalysingMinimumVisibleMilliseconds/AnalysingPaintDelayMillisecondsare test-adjustableinternal staticvalues;UiUtil.ScaledFontSize(12).Both current behaviors are explicitly preserved in this port. After those reconciliations, per-file diff counts match the original top commit exactly.
Validation
cd4ad6454a55651d6b2563fed0babc58b8be9991b56908f79f8e7d745d1cd77c865af30ca7fd1840FixDoubleGreaterThan -> Dialogtaxonomy assertionAI assistance: ChatGPT was used to port the stale stacked PR while preserving newer upstream testability and scaled-font behavior.