Skip to content

Port FixType filtering to current Fix common errors UI - #108

Draft
Blackspirits wants to merge 1 commit into
feature/fixtype-contract-c77cfrom
feature/fixtype-filter-c77c
Draft

Port FixType filtering to current Fix common errors UI#108
Blackspirits wants to merge 1 commit into
feature/fixtype-contract-c77cfrom
feature/fixtype-filter-c77c

Conversation

@Blackspirits

@Blackspirits Blackspirits commented Sep 13, 2026

Copy link
Copy Markdown
Owner

Purpose

Current-base audit/port of the top commit from upstream stack PR SubtitleEdit#14443, layered on draft #107.

This PR adds only the UI consumer of the FixType contract:

  • an All/Time/Formatting/Dialog/Punctuation/Casing/Spacing/Characters/OCR filter;
  • type filtering ANDed with the existing rule search;
  • the previously-created search box is actually added to the step-1 toolbar;
  • filtering always works from the profile's full rule list, preserving hidden rule selection;
  • profile switches retain the active filter;
  • type resolution comes from the fix classes, not a duplicated UI mapping;
  • language strings and focused UI tests are included.

Rebase integrity

The original top commit was based on a September 2 tree. Two later upstream improvements were present in current main but absent from the author's old branch:

  • AnalysingMinimumVisibleMilliseconds / AnalysingPaintDelayMilliseconds are test-adjustable internal static values;
  • two action labels use UiUtil.ScaledFontSize(12).

Both current behaviors are explicitly preserved in this port. After those reconciliations, per-file diff counts match the original top commit exactly.

Validation

AI assistance: ChatGPT was used to port the stale stacked PR while preserving newer upstream testability and scaled-font behavior.

@Blackspirits
Blackspirits force-pushed the feature/fixtype-filter-c77c branch from 5f9b0c3 to b56908f Compare September 13, 2026 22:51

@Blackspirits Blackspirits left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final independent re-check: this branch is now exactly one top commit on the final #107 HEAD. The stale author's branch would have reverted the current analyzing timing test hooks and two UiUtil.ScaledFontSize calls; both newer behaviors are preserved. Save/apply use AllFixRules, while Select all/Invert intentionally act only on visible filtered rows. The focused suite also pins FixDoubleGreaterThan to Dialog. Full CI #34788005507 passed restore, build and the complete solution suite on the first run; UITests reported 5,168 passed, 9 skipped and 0 failed. Retry was not used. No blocker identified. Keep draft; no merge performed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant