Skip to content

Reject unknown seconv MCP server options - #105

Draft
Blackspirits wants to merge 2 commits into
upl/review-base-mcp-ad51from
fix/mcp-strict-options-ad51
Draft

Reject unknown seconv MCP server options#105
Blackspirits wants to merge 2 commits into
upl/review-base-mcp-ad51from
fix/mcp-strict-options-ad51

Conversation

@Blackspirits

Copy link
Copy Markdown
Owner

Summary

The seconv README states a global CLI contract: an unrecognised option is an error, never a silent no-op.

Upstream PR SubtitleEdit#14129's McpServerHost.RunAsync only checks whether --verbose / -v is present and silently ignores every other argument. A typo such as seconv mcp --verbse therefore starts the server normally instead of failing, unlike the rest of seconv.

This change:

  • accepts only --verbose and -v after the mcp subcommand;
  • reports the first unknown option to stderr and returns exit code 1 before starting the protocol server;
  • adds a process-level regression test that runs seconv.dll mcp --verbse and verifies the failure contract.

Validation

AI assistance: ChatGPT was used to audit CLI/MCP argument-parsing parity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant