Reject unknown seconv MCP server options - #105
Draft
Blackspirits wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The seconv README states a global CLI contract: an unrecognised option is an error, never a silent no-op.
Upstream PR SubtitleEdit#14129's
McpServerHost.RunAsynconly checks whether--verbose/-vis present and silently ignores every other argument. A typo such asseconv mcp --verbsetherefore starts the server normally instead of failing, unlike the rest of seconv.This change:
--verboseand-vafter themcpsubcommand;seconv.dll mcp --verbseand verifies the failure contract.Validation
seconv mcp, a Model Context Protocol server over stdio SubtitleEdit/subtitleedit#14129 HEADad51c0ae9f5e8942f281e4acd82090974f9b8847AI assistance: ChatGPT was used to audit CLI/MCP argument-parsing parity.