Expose NOCR/BinaryOCR database path through seconv MCP - #104
Draft
Blackspirits wants to merge 2 commits into
Draft
Expose NOCR/BinaryOCR database path through seconv MCP#104Blackspirits wants to merge 2 commits into
Blackspirits wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstream PR SubtitleEdit#14129 exposes
convert_subtitle.ocrEnginewithnocrandbinaryocras supported values, but the MCP tool does not expose the database path required by either engine.The shared OCR factory requires:
nocr→ConversionOptions.OcrDbpointing to a.nocrdatabase;binaryocr→ the same option pointing to a.dbdatabase.Because SubtitleEdit#14129 leaves
OcrDbnull unconditionally, those two advertised MCP engine choices cannot succeed on image-based input.This change:
ocrDbtoconvert_subtitle;ConversionOptions.OcrDb;Validation
seconv mcp, a Model Context Protocol server over stdio SubtitleEdit/subtitleedit#14129 HEADad51c0ae9f5e8942f281e4acd82090974f9b8847AI assistance: ChatGPT was used to audit behavioral parity between the new MCP tool surface and seconv's existing CLI/core OCR options.