Skip to content

Expose NOCR/BinaryOCR database path through seconv MCP - #104

Draft
Blackspirits wants to merge 2 commits into
upl/review-base-mcp-ad51from
fix/mcp-ocr-database-ad51
Draft

Expose NOCR/BinaryOCR database path through seconv MCP#104
Blackspirits wants to merge 2 commits into
upl/review-base-mcp-ad51from
fix/mcp-ocr-database-ad51

Conversation

@Blackspirits

Copy link
Copy Markdown
Owner

Summary

Upstream PR SubtitleEdit#14129 exposes convert_subtitle.ocrEngine with nocr and binaryocr as supported values, but the MCP tool does not expose the database path required by either engine.

The shared OCR factory requires:

  • nocrConversionOptions.OcrDb pointing to a .nocr database;
  • binaryocr → the same option pointing to a .db database.

Because SubtitleEdit#14129 leaves OcrDb null unconditionally, those two advertised MCP engine choices cannot succeed on image-based input.

This change:

  • adds optional ocrDb to convert_subtitle;
  • documents that it is required for NOCR/BinaryOCR and which extensions they use;
  • passes the value through to ConversionOptions.OcrDb;
  • leaves Tesseract/Ollama/Paddle/llama.cpp behavior unchanged.

Validation

AI assistance: ChatGPT was used to audit behavioral parity between the new MCP tool surface and seconv's existing CLI/core OCR options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant