Wire API-Route prompt into translate settings - #101
Draft
Blackspirits wants to merge 1 commit into
Draft
Conversation
Blackspirits
commented
Sep 13, 2026
Blackspirits
left a comment
Owner
Author
There was a problem hiding this comment.
Independent adversarial re-check: upstream SubtitleEdit#14836 adds ApiRoutePrompt to runtime/persisted settings but omits ApiRouteTranslate from TranslateSettingsViewModel's prompt contract. Without this patch the prompt editor is hidden, reset/save do not handle ApiRoutePrompt, and {0}/{1} placeholder validation is skipped. The final diff mirrors existing OpenRouter/Groq wiring in exactly those three places and changes no API transport/model behavior. Full CI #34780482268 passed restore, build and the complete suite on the first run; UITests reported 5,149 passed, 9 skipped, 0 failed. Retry was not used. No blocker identified in the fix. Keep draft; no merge performed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstream PR SubtitleEdit#14836 adds
ApiRoutePromptto both runtime and persisted auto-translate settings, but does not registerApiRouteTranslateinTranslateSettingsViewModel.As a result, the per-engine Translate settings dialog treats API-Route as an engine without a configurable prompt:
GetPromptreturns null;{0}/{1}source/target placeholder validation is skipped.This change mirrors the existing OpenRouter/Groq/etc. wiring:
ApiRoutePromptto bothSe.SettingsandConfiguration.Settings.Tools;GetPrompt.Validation
d47d366133e62a876b72c598289a537b41170235Note: API-Route's current documentation says supported models change over time and the Pricing page is the source of truth. SubtitleEdit#14836's static model suggestions are therefore maintenance debt, but Model is a free-text field, so that is not part of this functional prompt fix.
AI assistance: ChatGPT was used to adversarially review the new API-Route auto-translator's settings/persistence integration.