[agbishop]

Migrates all JSON handling from encoding/json (v1) to encoding/json/v2 + encoding/json/jsontext. No GOEXPERIMENT/GODEBUG/env vars: Go 1.27 ships json/v2 by default; this changes import paths and call sites. Behaviour and wire output stay byte-identical.

What changed

• pkgs/jsonx — the only package that still imports v1 (it owns json.DefaultOptionsV1()):
  • jsonx.V1() options passed on every Marshal/Unmarshal/stream call → identical output and v1 error text.
  • jsonx.Number / UseNumber(), SDKDecoder (for AWS SDK helpers that need a v1 *Decoder).
  • IsSyntaxError / IsTypeError / SyntaxError / TypeError: with V1 options the v2 engine still returns the v1 error types, so errors.As on jsontext.SyntacticError/json.SemanticError silently stops matching — these helpers accept both.
  • Package doc holds the full v1→v2 mapping table and gotchas (token invalidation, whitespace options belong on NewEncoder, trailing-data checks via InputOffset).
• cmd/jsonv2mod: AST codemod used for the bulk rewrite (~4,400 files across pkgs/, internal/, services/, test/, cmd/, dashboard/, demo/); unsafe sites were reported and hand-fixed.
• test/guards/jsonv1_import_guard_test.go: AST guard — no encoding/json import outside pkgs/jsonx (string-literal fixtures and testdata excluded).
• Separate example modules use encoding/json/v2 directly.

Verification

• Golden wire tests (DynamoDB, SQS, CloudWatch JSON envelopes, JSON error envelopes) written before the swap, unchanged after.
• Race tests over every migrated package; SDK parity integration samples (DynamoDB, Kinesis, Lambda, CloudWatch, EventBridge, Glue, Athena, ECS, ECR, KMS, Firehose, Cognito, S3, SQS, SNS, SSM, Secrets Manager, Step Functions, STS, Route 53, RDS, Redshift, SES, SageMaker, Transcribe, Timestream, X-Ray) green.
• Bugs found on the way and fixed: wfinterp test signal race (CI hang); ParseJSON trailing-garbage acceptance introduced mid-migration; Glue token-lifetime panic; application auto scaling 500-vs-400 from the error-type assumption.
• Persistence snapshot inventory only renames json.RawMessage → jsontext.Value; persisted JSON unchanged.

bd: gopherstack-9rpwg (closed)

🤖 Generated with Claude Code

https://claude.ai/code/session_01FGWXecoauvZN2AYe1vkvgM

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[codecov]

Codecov Report

❌ Patch coverage is 80.56497% with 172 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
cmd/jsonv2mod/main.go	0.00%	54 Missing ⚠️
cmd/jsonv2mod/rewrite.go	90.59%	27 Missing ⚠️
cmd/cfnpropgen/main.go	0.00%	13 Missing ⚠️
dashboard/ui.go	10.00%	9 Missing ⚠️
pkgs/jsonx/jsonx.go	84.74%	9 Missing ⚠️
cmd/retypesgen/main.go	0.00%	6 Missing ⚠️
cmd/cfnattrgen/main.go	50.00%	3 Missing ⚠️
pkgs/odatatable/codec.go	76.92%	3 Missing ⚠️
cmd/acceptguard/report.go	0.00%	2 Missing ⚠️
cmd/bdaudit/report.go	0.00%	2 Missing ⚠️
... and 26 more

📢 Thoughts on this report? Let us know!

[agbishop]

📊 Code Coverage Report

Metric	Value	Status
Total Coverage	100.0%
0.0%
0.0%
0.0%
100.0%
75.0%
100.0%
100.0%
0.0%
86.7%	✅
New Code Coverage	N/A (0/0 stmts)	✅

Tip

This project maintains a minimum coverage threshold of 85%. Maintain or improve coverage on new code to ensure long-term stability.

---

Last updated: Sun, 01 Nov 2026 23:30:56 GMT