feat(awm): fix recovery handlers to support dual key provider#197
Merged
margueriteblair merged 1 commit intomasterfrom May 9, 2026
Conversation
margueriteblair
changed the title
margueriteblair
force-pushed
the
margieblair/wcn-363-akm-fix-recovery-handlers-to-support-dual-key-provider
branch
5 times, most recently
from
86ef8bf to
b5bd309
Compare
Contributor
Author
margueriteblair
force-pushed
the
margieblair/wcn-363-akm-fix-recovery-handlers-to-support-dual-key-provider
branch
from
b5bd309 to
aaab565
Compare
pranishnepal
reviewed
May 8, 2026
| ...(cfg.backupKmsClientTlsCert !== undefined && { | ||
| keyProviderClientTlsCert: cfg.backupKmsClientTlsCert, | ||
| }), | ||
| ...(cfg.backupKmsServerCertAllowSelfSigned !== undefined && { |
Contributor
There was a problem hiding this comment.
we're doing in the config:
readEnvVar('BACKUP_KMS_SERVER_CERT_ALLOW_SELF_SIGNED') === 'true',
so that value will always be true or false, never undefined // we should either set:
readEnvVar('BACKUP_KMS_SERVER_CERT_ALLOW_SELF_SIGNED')
Or update the check here to validate boolean (maybe the former is better)
margueriteblair
force-pushed
the
margieblair/wcn-363-akm-fix-recovery-handlers-to-support-dual-key-provider
branch
from
aaab565 to
3cae6fc
Compare
pranishnepal
previously approved these changes
May 8, 2026
margueriteblair
force-pushed
the
margieblair/wcn-363-akm-fix-recovery-handlers-to-support-dual-key-provider
branch
from
3cae6fc to
decefd1
Compare
pranishnepal
approved these changes
May 9, 2026
margueriteblair
deleted the
margieblair/wcn-363-akm-fix-recovery-handlers-to-support-dual-key-provider
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.