fix: exclude GHSA-rpmf-866q-6p89 (basic-ftp DoS) from yarn audit to unblock publish#8704
Closed
Doddanna17 wants to merge 1 commit intomasterfrom
Closed
fix: exclude GHSA-rpmf-866q-6p89 (basic-ftp DoS) from yarn audit to unblock publish#8704Doddanna17 wants to merge 1 commit intomasterfrom
Doddanna17 wants to merge 1 commit intomasterfrom
Conversation
DoS via unbounded multiline FTP control response buffering in basic-ftp. Same transitive chain as the already-excluded GHSA-rp42-5vxx-qpwr: pac-proxy-agent > get-uri > basic-ftp, used only for PAC proxy resolution. All 5 yarn audit findings are the same advisory across different dep paths. Ticket: SI-512
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ticket: SI-512
Summary
GHSA-rpmf-866q-6p89to.iyarcto exclude it from the yarn audit checkchore(root): publish modulesCI job which was failing with 5 HIGH severity findings — all the same advisory (GHSA-rpmf-866q-6p89) reported across 5 different dependency paths throughbasic-ftpWhy the exclusion is safe
The vulnerability is a client-side DoS in
basic-ftpvia unbounded multiline FTP control response buffering. The affected package reaches us through:basic-ftpis used only for PAC-based proxy URL resolution, not for direct FTP operationsGHSA-rp42-5vxx-qpwr, DoS viaClient.list()) is already excluded under the same rationaleget-uridependency chainImpact
Unblocks the publish of
@bitgo/sdk-coin-hbarcontaining theexplainTransactionfix for HBAR staking (PR #8700, merged), which is needed to unblock end-to-end HBAR stake signing on staging.Related
explainTransactionfix for HBAR (PR fet(hbar): add AccountUpdate support to explainTransaction in BitGoJS #8700)stakedNodeIdfix