Skip to content

fix(sdk-coin-xdc): add tokenApproval to verifyTssTransaction#8703

Merged
ArunBala-Bitgo merged 1 commit intomasterfrom
CECHO-915
May 7, 2026
Merged

fix(sdk-coin-xdc): add tokenApproval to verifyTssTransaction#8703
ArunBala-Bitgo merged 1 commit intomasterfrom
CECHO-915

Conversation

@ArunBala-Bitgo
Copy link
Copy Markdown
Contributor

@ArunBala-Bitgo ArunBala-Bitgo commented May 6, 2026

the bypass list in xdcToken.ts and xdc.ts was copied from a stale bscToken.ts and was missing tokenApproval and consolidate transaction types. This caused enableToken (TXCD:TMT) to fail with "missing txParams" because tokenApproval transactions have no recipients and were not in the bypass list.

Fixes CECHO-915.

Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com

TICKET: CECHO-915

…saction bypass list

The bypass list in xdcToken.ts and xdc.ts was copied from a stale bscToken.ts
and was missing tokenApproval and consolidate transaction types. This caused
enableToken (TXCD:TMT) to fail with "missing txParams" because tokenApproval
transactions have no recipients and were not in the bypass list.

Fixes CECHO-915. Introduced in commit 03d5339 (COIN-7060).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

TICKET: CECHO-915
@ArunBala-Bitgo ArunBala-Bitgo requested a review from a team as a code owner May 6, 2026 19:41
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 6, 2026

@ArunBala-Bitgo ArunBala-Bitgo marked this pull request as draft May 6, 2026 19:43
@ArunBala-Bitgo ArunBala-Bitgo changed the title fix(sdk-coin-xdc): add tokenApproval and consolidate to verifyTssTran… fix(sdk-coin-xdc): add tokenApproval to verifyTssTransaction May 7, 2026
@ArunBala-Bitgo ArunBala-Bitgo marked this pull request as ready for review May 7, 2026 04:47
Copy link
Copy Markdown
Contributor

@MohammedRyaan786 MohammedRyaan786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArunBala-Bitgo ArunBala-Bitgo merged commit aab8d0d into master May 7, 2026
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants