eth: reject malformed typed data safely - #172
Open
Tomasvrba wants to merge 1 commit into
Open
Conversation
Tomasvrba
force-pushed
the
typed-data-fix
branch
from
July 23, 2026 04:45
02e7153 to
7817efe
Compare
Decode EIP-712 payloads into typed structures and return errors for malformed JSON structures, value paths, and scalar types instead of panicking during firmware requests. eth: validate typed data string fields Reject missing or null primaryType and member names before sending a malformed request to the firmware. eth: preserve exact typed data keys Use checked map lookups so differently cased fields cannot replace fields used for signing.
Tomasvrba
force-pushed
the
typed-data-fix
branch
from
July 23, 2026 04:52
7817efe to
f3f0816
Compare
benma
approved these changes
Jul 24, 2026
benma
left a comment
benma
left a comment
Contributor
There was a problem hiding this comment.
Should disable goconst in all our repos, that linter annoy more than it helps 😅
Collaborator
Author
Yeah, I think the fix is worse than the actual issue 👎 :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decode EIP-712 payloads into typed structures and return errors for malformed JSON structures, value paths, and scalar types instead of panicking during firmware requests.
Tightens validation in the API in preparation for Wallet Connect upgrades