Fix omnicorp support graph appended to result once per curie pair#111
Merged
Conversation
In add_shared_pmid_counts, the OMNICORP support graph id was appended to an analysis's support_graphs list unconditionally for every curie pair referencing that analysis. Since a single analysis is referenced by every combination of its nodes, the same OMNICORP_support_graph_N id was added to support_graphs many times over. Only attach the id when the support graph is first created (matching the upstream aragorn-ranker behavior); reused graphs still collect the new co-occurrence edges but no longer re-append their id. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016hGUK358FjydvopTS5kt4X
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In add_shared_pmid_counts, the OMNICORP support graph id was appended to an analysis's support_graphs list unconditionally for every curie pair referencing that analysis. Since a single analysis is referenced by every combination of its nodes, the same OMNICORP_support_graph_N id was added to support_graphs many times over.
Only attach the id when the support graph is first created (matching the upstream aragorn-ranker behavior); reused graphs still collect the new co-occurrence edges but no longer re-append their id.
Claude-Session: https://claude.ai/code/session_016hGUK358FjydvopTS5kt4X