fix: restore app-server model patch on Codex 26.707+#1453
Open
WAYLON wants to merge 1 commit into
Open
Conversation
Owner
|
Codex++ maintainer review note 当前 main 下这个 PR 仍存在 merge conflict,暂时不能合并。请先 rebase 到最新 main 并解决冲突;更新后我们会重新跑针对性测试再复审。 This PR currently conflicts with main, so it is not mergeable yet. Please rebase onto the latest main and resolve the conflicts, then we can review and test it again. |
Codex desktop 26.623+/26.707 removed the standalone app-server-manager-signals-* asset, so model whitelist and plugin marketplace request patches failed with "未找到 Codex App asset". Discover sendRequest clients from current app bundles as a fallback while still trying the legacy asset name first.
WAYLON
force-pushed
the
fix/app-server-model-patch-fallback-26-707
branch
from
July 26, 2026 15:16
a656fc4 to
f1e79ac
Compare
Author
|
已 rebase 到最新 冲突处理要点:
验证:
补充:宽泛执行 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
26.623+/26.707+no longer ships the standaloneapp-server-manager-signals-*asset.未找到 Codex App asset: app-server-manager-signals-, and never patchsendRequest.sendRequestclients from currently loaded app bundles (app-initial/app-mainchunks).Root cause
installAppServerModelRequestPatch()andinstallPluginMarketplaceRequestPatch()both did:On current ChatGPT/Codex app (
26.707.41301verified), that filename prefix does not exist. The client was inlined into larger bundles, so the module loader throws and the model list injection path stalls.Changes
assets/inject/renderer-inject.jsloadAppServerRequestCandidates()discovery helpersendRequestclients from module exportscrates/codex-plus-core/tests/cdp_bridge.rsTest plan
cargo test -p codex-plus-core --test cdp_bridge injection_scriptcargo build -p codex-plus-launcher --releasecodex-plus-plusbinary and restart Codex via Codex++model_app_server_request_patch_installedinstead of..._failedmodelList/ catalog appear in the model selectorNotes
Related: #1324, #1210
Verified against local Codex app:
/Applications/ChatGPT.app26.707.41301sendRequestexport on current app bundle