Skip to content

fix: harden relay profile configuration updates - #1396

Open
superman2003 wants to merge 1 commit into
BigPizzaV3:mainfrom
superman2003:codex/fix-audit-bugs
Open

fix: harden relay profile configuration updates#1396
superman2003 wants to merge 1 commit into
BigPizzaV3:mainfrom
superman2003:codex/fix-audit-bugs

Conversation

@superman2003

Copy link
Copy Markdown
Contributor

Summary

  • make model catalog, config.toml, and auth.json updates share one locked transactional write path with rollback
  • reject malformed relay profiles and invalid or overflowing model window values
  • keep relay profile UI, persisted settings, and live Codex files consistent on save and delete failures
  • fix stale per-model catalogs, suffix updates, unmanaged context preservation, and custom catalog cleanup
  • recognize the official ChatGPT Desktop package in the Windows watcher
  • stabilize model window row keys and add frontend validation

Tests

  • cargo fmt --all -- --check
  • cargo check -p codex-plus-core
  • cargo test -p codex-plus-core --tests --no-fail-fast
  • cargo test -p codex-plus-data --no-fail-fast
  • node --experimental-strip-types --test src/model-windows.test.ts (11 passed)

Environment notes

  • cargo test --workspace reached the Tauri manager but could not compile generate_context because frontend dist is absent; this checkout has no node_modules, so vite and tsc were not installed locally
  • codex-plus-launcher compiled, but Windows refused to execute its requireAdministrator test binary without elevation (os error 740)

@BigPizzaV3

Copy link
Copy Markdown
Owner

Codex++ maintainer review note

当前 main 下这个 PR 仍存在 merge conflict,暂时不能合并。请先 rebase 到最新 main 并解决冲突;更新后我们会重新跑针对性测试再复审。

This PR currently conflicts with main, so it is not mergeable yet. Please rebase onto the latest main and resolve the conflicts, then we can review and test it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants