Skip to content

fix: kill discord before writing betterdiscord.asar #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Huderon wants to merge 1 commit into
base: development
Choose a base branch
from
Open

fix: kill discord before writing betterdiscord.asar #428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions discord/install.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,20 +41,20 @@ func (discord *DiscordInstall) InstallBD(options types.InstallOptions) error {
log.Println("✅ BetterDiscord prepared for install")
log.Println("")

// Download and write betterdiscord.asar
log.Println("📥 Downloading BetterDiscord...")
if err := bd.Download(options.UseDevBuild); err != nil {
// Discord locks app.asar and betterdiscord.asar while running, so it must be stopped before we can
// modify it. Capture the executable so it can be relaunched afterward.
exe, wasRunning, err := discord.stop()
if err != nil {
return err
}
log.Println("✅ BetterDiscord downloaded")
log.Println("")

// Discord locks app.asar while running, so it must be stopped before we can
// modify it. Capture the executable so it can be relaunched afterward.
exe, wasRunning, err := discord.stop()
if err != nil {
// Download and write betterdiscord.asar
log.Println("📥 Downloading BetterDiscord...")
if err := bd.Download(options.UseDevBuild); err != nil {
return err
}
log.Println("✅ BetterDiscord downloaded")
log.Println("")

// Shadow app.asar with our loader
Expand Down