Useless function?? #1

Activity

1. Benjamincf0 commented on Mar 17, 2026

   

   Benjamincf0

   on Mar 17, 2026

   OwnerAuthor

   More actions

   /oc explain this issue and how to resolve it
2. opencode-agent commented on Mar 17, 2026

   

   opencode-agentBot

   on Mar 17, 2026 – with OpenCode Agent

   Contributor

   More actions

   Analysis

   The issue is valid. Both functions do the same thing:

   Aspect	waitFor	waitForElement
   Lines	3-13	15-35
   API	Callback-based	Promise-based
   Initial check	No	Yes (sync query first)
   Observes	document.body	document
   Usage	5 times (strategy.ts)	1 time (uimanager.ts)

   Both use MutationObserver to wait for DOM elements matching a selector, then disconnect and return the element.

   Resolution

   The functions are redundant. Recommend keeping waitFor (used more frequently) and consolidating waitForElement into it:

   1. Replace the single usage in uimanager.ts to use waitFor with a callback
   2. Remove waitForElement from utils.ts

   This simplifies maintenance. Want me to make these changes?

   
   opencode session  |  github run
3. Benjamincf0 commented on Mar 17, 2026

   

   Benjamincf0

   on Mar 17, 2026

   OwnerAuthor

   More actions

   /oc ok sure do that and then make a pr
4. opencode-agent commented on Mar 17, 2026

   

   opencode-agentBot

   on Mar 17, 2026 – with OpenCode Agent

   Contributor

   More actions

   Created PR #2

   
   opencode session  |  github run
5. Benjamincf0

   closed this as completedin #2on Mar 17, 2026