Optimize include parsing with per-file caching#19
Merged
Conversation
…ne boundary The line_count_adjustment was subtracted instead of added, causing segments after include replacements to report line numbers off by the number of stripped trailing newlines. Also handle the case where the stripped newline is the only line crossing (start_column should reset to 1). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Parse each included file independently instead of concatenating all sources into one giant string. Each file's AST is cached to disk (pickle) so subsequent parses of unchanged files load in ~1s instead of 45+s. Also replace the O(n²) recursive _get_node_end_position with Arpeggio's built-in position_end attribute. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_get_node_end_positionwith Arpeggio's built-inposition_endattribute_replace_textline count whenstrip_trailing_newlinecrosses a line boundaryPerformance
Test plan
test_use_include.py)test_ast_convenience.py) — caching, invalidation, include processingprocess_includes=Falsecorrectly preserves IncludeStatement nodes🤖 Generated with Claude Code