Repository navigation
Conversation
The exported owner (viewer) key was always encrypted with the wallet password, so running a node that watches the wallet meant putting the wallet password on the node (its --pass / config), often a remote server. Add --owner_key_pass: when given, the key is encrypted with it and the node is started with that password instead. Without it nothing changes (same key as before); the output now says which password the key is encrypted with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix:
beam-wallet export_owner_key --owner_key_pass=<pw>encrypts the exported owner (viewer) key with its own password, so the node that uses it doesn't need the wallet password (#401; option A of #891).Why: the key was always encrypted with the wallet password, and
beam-node --owner_key=… --pass=…needs that password to use it. Anyone running a node that watches their wallet (often a remote server, started by systemd) had to put the wallet password into the node's command line or config.How to see the bug (master)
Improvement
export_owner_key(no option)export_owner_key --owner_key_pass=nodepwnodepw; "Give the node that password, not the wallet password."beam-node --owner_key=<that key> --pass=nodepwbeam-node --owner_key=<that key> --pass=walletpwkey import failed--owner_key_pass ""--owner_key_pass must not be emptyNodes need no changes: they already take the key's password through
--pass.Testing: all rows above were run with master's and this branch's
beam-wallet, and with this branch'sbeam-node. Fork CI (running): https://github.com/vsnation/beam/actions/runs/Fixes #401