Repository navigation
Conversation
A request that failed to parse was logged in full, so any client could grow the log by up to 1 MB per request (64 KB per line in TCP mode). executeAPIRequest and fromError now log the first 1024 bytes and the request size.
|
Heads-up on an overlap: #2119 changes the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2148.
When a request failed to parse,
ApiBase::executeAPIRequestandApiBase::fromErrorwrote the whole request to the warning log. Any client that can reach the API port could grow the log by up to 16 MB per request (the HTTP body limit; 64 KB per line in TCP mode) and fill the disk.Fix
Both warnings now log the first 1024 bytes plus the request size, e.g.
"xxxx…... (1000000 bytes). This matchesstratum::parse_json, which already logs at most 1024 bytes. Short requests are logged unchanged.Tests
wallet_api_testpasses.wallet-api --use_http=1, sending invalid 1 MB bodies (junk and an unterminated string). Before: 20 requests added 20 MB to the log. After: 40 requests added 48 KB, and the API keeps serving.Merges cleanly with #2145 and #2146 (checked with
git merge-tree).