added LootableRandom tag - #8
Open
shadoxxhd wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds LootableRandom tag, allowing drops to be randomized:
If
"no_salvage"is set, it chooses a random option to drop instead of the original item. The normalLootabletag is ignored whenLootableRandomis set and valid, otherwise it falls back toLootable.Weighting is linear (drop chance is proportional to weight -
P(option) = weight(option)/sum(weights)).Since one significant use case for
LootableRandomis to add rare drops to items while still usually dropping the item itself, the"no_salvage"flag is ignored for the replacement item (both forLootableandLootableRandom).This behavior could technically be restricted to LootableRandom, keeping the
"no_salvage"behavior of the normalLootabletag, if desired - the question is whether to simplify the behavior, or keep backwards compatibility of rare "noop" edge cases.