Repository navigation
Conversation
Owner
Author
|
Closing as redundant: the current base branch
The integration branch therefore already includes this exact Reduce Transparency implementation and tests. The natural exact-head run for the integration branch is #394, which passed JVM tests and APK assembly. This PR is being closed without merging; the code remains in PR #34's base. Physical-device screenshot/TalkBack/Reduce Transparency verification is still outstanding. |
Batmancpu
deleted the
a11y/dictionary-popup-reduce-transparency-2026-11-09
branch
November 14, 2026 10:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evidence
The active integration branch adds an app-wide Reduce Transparency preference in You → Settings → Appearance and persists it through
LocalStore.reduceTransparency().The standalone dictionary popup (
DictionaryActivity, exported for AndroidACTION_PROCESS_TEXT) did not read that preference. It unconditionally enabledFLAG_BLUR_BEHINDon Android 12+ and kept the translucent popup surface at alpha 0.86. The popup therefore ignored the user's saved Reduce Transparency choice even though the rest of the integration UI consumes it.The active consolidation is PR #34. This proposal is deliberately stacked on its integration branch rather than creating a main-based change that cannot compile against main's older LocalStore (which does not yet contain the integration appearance preference).
Change
LocalStore.reduceTransparency(applicationContext)onDispatchers.IO; do not load the shared preferences file on the popup's main thread.FLAG_BLUR_BEHINDand use a 0.985 surface alpha.DictionarySurfacePolicyand four JVM tests covering reduced/normal appearance on modern/legacy Android.Verification — 9 November 2026
Natural PR validation passed.
55afb9ab662d2926675f0a57737d3f817b1fc2cb.:app:testDebugUnitTest: passed.:app:assembleDebug: passed.The integration base advanced by one unrelated commit after this branch was created:
black-box-bihar-news@11b709aa9f357437fa7315035d4a383b79d7d4af. This PR is three commits ahead / one behind that branch; GitHub currently reports it mergeable with a clean merge state. The intervening commit changes feed-navigation/UI and documentation files, not the dictionary popup. That updated base independently passed natural push #387 and PR #388, including JVM tests, APK assembly and artifact upload. Those runs validate the base commit, not a rebased combined PR #46 head.Risks / limitations
Canonical main remains unchanged.