Skip to content

Remove unused PERMISSION_PHOTOS_ADD_ONLY macro (#986) #1567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ibrahim-iqbal wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −12
Open

Remove unused PERMISSION_PHOTOS_ADD_ONLY macro (#986) #1567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion permission_handler/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ The following lists the relationship between `Permission` and `The key of Info.p
| PermissionGroup.microphone | NSMicrophoneUsageDescription | PERMISSION_MICROPHONE |
| PermissionGroup.speech | NSSpeechRecognitionUsageDescription | PERMISSION_SPEECH_RECOGNIZER |
| PermissionGroup.photos | NSPhotoLibraryUsageDescription | PERMISSION_PHOTOS |
| PermissionGroup.photosAddOnly | NSPhotoLibraryAddUsageDescription | PERMISSION_PHOTOS_ADD_ONLY |
| PermissionGroup.photosAddOnly | NSPhotoLibraryAddUsageDescription | PERMISSION_PHOTOS |
| PermissionGroup.location, PermissionGroup.locationAlways, PermissionGroup.locationWhenInUse | NSLocationUsageDescription, NSLocationAlwaysAndWhenInUseUsageDescription, NSLocationWhenInUseUsageDescription | PERMISSION_LOCATION |
| PermissionGroup.locationWhenInUse | NSLocationWhenInUseUsageDescription | PERMISSION_LOCATION_WHENINUSE |
| PermissionGroup.notification | PermissionGroupNotification | PERMISSION_NOTIFICATIONS |
Expand Down
4 changes: 0 additions & 4 deletions permission_handler_apple/ios/permission_handler_apple/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,10 +664,6 @@ let permissionDefines: [CSetting] = [
to: enabled("PERMISSION_PHOTOS",
plistKeys: "NSPhotoLibraryUsageDescription",
"NSPhotoLibraryAddUsageDescription")),
// dart: PermissionGroup.photosAddOnly
.define("PERMISSION_PHOTOS_ADD_ONLY",
to: enabled("PERMISSION_PHOTOS_ADD_ONLY",
plistKeys: "NSPhotoLibraryAddUsageDescription")),
// dart: PermissionGroup.location / locationAlways / locationWhenInUse
.define("PERMISSION_LOCATION",
to: enabled("PERMISSION_LOCATION",
Expand Down
7 changes: 0 additions & 7 deletions ...le/ios/permission_handler_apple/Sources/permission_handler_apple/PermissionHandlerEnums.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,6 @@
#define PERMISSION_PHOTOS 0
#endif

// ios: PermissionGroupPhotosAddOnly
// Info.plist: NSPhotoLibraryAddUsageDescription
// dart: PermissionGroup.photosAddOnly
#ifndef PERMISSION_PHOTOS_ADD_ONLY
#define PERMISSION_PHOTOS_ADD_ONLY 0
#endif

// ios: [PermissionGroupLocation, PermissionGroupLocationAlways, PermissionGroupLocationWhenInUse]
// Info.plist: [NSLocationUsageDescription, NSLocationAlwaysAndWhenInUseUsageDescription, NSLocationWhenInUseUsageDescription]
// dart: [PermissionGroup.location, PermissionGroup.locationAlways, PermissionGroup.locationWhenInUse]
Expand Down
Loading