Repository navigation
feat(tasks): select review mode during Task creation - #299
Merged
Merged
Conversation
…er handoff Create Tasks through create_task in each mode, start them through the executor's real run-start write, and assert the stored WorkerHandoff in memory and on disk. Correct the neighbouring test comment to match what it asserts.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 40 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
shingonoide
changed the title
shingonoide
marked this pull request as draft
November 2, 2026 23:36
shingonoide
marked this pull request as ready for review
November 2, 2026 23:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lets the user choose Manual or Automatic review mode when creating a Task, in the GUI and the CLI. The chosen mode is stored with the Task and copied into the Worker handoff when a run starts. Omitting the mode keeps the existing default (Automatic), so existing clients are unchanged.
Changes
reviewModeand stores it in the same write as the new Task.slashit create --review-mode manual|automatic.Known limitation
The CLI and IPC create path does not set the coding provider; a Task created there uses the default provider.
Tests
commands::task::task_dependency_contractcreates Tasks in each mode and without a mode, then checks the stored Worker handoff after a run start, in memory and after reload.