Fix: Make arcana a PUBLIC dependency of AppRuntime#153
Closed
bghgary wants to merge 1 commit intoBabylonJS:mainfrom
Closed
Fix: Make arcana a PUBLIC dependency of AppRuntime#153bghgary wants to merge 1 commit intoBabylonJS:mainfrom
bghgary wants to merge 1 commit intoBabylonJS:mainfrom
Conversation
AppRuntime.h includes arcana/threading/cancellation.h and arcana/threading/dispatcher.h in its public header. Consumers need arcana's include directories to compile. Changed from PRIVATE to PUBLIC. This was broken by BabylonJS#149 which moved arcana includes into the public header when merging WorkQueue into AppRuntime. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a build-system visibility issue by making arcana a PUBLIC dependency of AppRuntime, ensuring consumers of AppRuntime receive arcana’s include directories when AppRuntime.h includes <arcana/...> headers.
Changes:
- Update
Core/AppRuntime/CMakeLists.txtto linkarcanaasPUBLICinstead ofPRIVATE.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Closing — making arcana PUBLIC is wrong. The fix should hide arcana behind a pimpl pattern instead. |
Contributor
Author
|
[Responded by Copilot on behalf of @bghgary] Closing - making arcana PUBLIC exposes implementation details in the public API. Will fix with pimpl pattern instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make arcana a PUBLIC dependency of AppRuntime.
The Bug
AppRuntime.hincludesarcana/threading/cancellation.handarcana/threading/dispatcher.h, but AppRuntime linked arcana asPRIVATE. Consumers of AppRuntime (like BabylonNative's UnitTests) didn't get arcana's include directories, causing build failures.Root Cause
PR #149 (Merge WorkQueue into AppRuntime) moved arcana includes into the public
AppRuntime.hheader. The link visibility should have been updated toPUBLICat the same time.The Fix
Change
PRIVATE arcanatoPUBLIC arcanainCore/AppRuntime/CMakeLists.txt.