Support Version v26

[GCRA101]

Issues addressed by this PR

Fixes #318

BHoM SAP2000 Toolkit now supporting SAP2000 v26.

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/SAP2000_Toolkit/%23334-SupportVersionV26?csf=1&web=1&e=r8zLzB

Changelog

• Created libs/v26/ folder containing assemblies for SAP2000 v26
• Referenced CSiAPIv1.dll and SAP2000v1.dll for SAP2000 v26

Additional comments

• To be tested with older versions of SAP2000 to check compatibility prior to merge.

[GCRA101]

@samuelbasimalla,
Checked this thouroughly for SAP2000 V26 and it works fine.
As mentioned, if you could test this with your SAP2000 v25 license that would be really amazing test of retro-compatibility (I don't have access to v25 license in London unfortunately)
Thanks a lot for your help. (test files are the standard ones used for general toolkits testing) ;).
Any questions, let me know :)

[samuelbasimalla]

@GCRA101
Tested this on SAP2000 Version 25.1.0 to check retro compatibility.
I am using Rhino 7 for testing.

As communicated in the chat, I couldn't build the solution as both the dll references CSiAPIv1.dll and SAP2000v1.dll for SAP2000 v25 cannot be found. I had to reference them again in V25 folder of my machine for the build to be successful.

I tested the script in Structures - Create - Read - Update - Elements.
It is generally working as intended with right warning messages like Levels not being supported by SAP2000 adapter.
I noticed the time taken to create elements is similar to a ETABS adapter however, the time taken to update the elements is much longer than a ETABS adapter.

This is for your initial feedback, I will proceed with testing other scripts and provide comments in due course.

[bhombot-ci]

@GCRA101 fix requested for project compliance.

The errors with the CSProject (.csproj) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix project file ref. 63814872786

[GCRA101]

@BHoMBot fix project file ref. 63814872786

[bhombot-ci]

@GCRA101 I have queued up your request to fix the csproj file(s). There are 0 requests in the queue ahead of you.

[bhombot-ci]

@GCRA101 I am now going to fix the project compliance in accordance with the annotations previously made.

[bhombot-ci]

@GCRA101 to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request.

[GCRA101]

@BHoMBot check installer

[bhombot-ci]

@GCRA101 to confirm, the following actions are now queued:

• check installer

[GCRA101]

@BHoMBot check installer

[bhombot-ci]

@GCRA101 to confirm, the following actions are now queued:

• check installer

[GCRA101]

@BHoMBot check installer

[bhombot-ci]

@GCRA101 I am now going to fix the project compliance in accordance with the annotations previously made.

[bhombot-ci]

@GCRA101 to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request.

[GCRA101]

@BHoMBot check installer

[bhombot-ci]

@GCRA101 to confirm, the following actions are now queued:

• check installer

There are 5 requests in the queue ahead of you.

[GCRA101]

@BHoMBot check installer

[bhombot-ci]

@GCRA101 to confirm, the following actions are now queued:

• check installer

There are 3 requests in the queue ahead of you.

[GCRA101]

@BHoMBot check required

[bhombot-ci]

@GCRA101 to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

There are 2 requests in the queue ahead of you.

[bhombot-ci]

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

[samuelbasimalla]

@GCRA101
Tested this on SAP2000 Version 25.1.0 to check retro compatibility.
I am using Rhino 7 for testing.

I am able to successfully build the solution in my machine.

I tested the script in Structures - Create - Read - Update - Elements and Structures - Create non-existing

Based on the two tested scripts, it is working as intended.

Do we want to remove the capability to push levels as SAP2000 doesn't support this? Or we can also leave it like it is now as it still gives a warning message to notify the user levels are not supported by SAP2000 adapter.

[GCRA101]

@samuelbasimalla,

thanks a lot for your review. That's super good news!

For the levels we can do either. Now that we have the Adapter working with v26 and also works for retro-compatibility we can crack on that as well as all other features :).
I would be tempted to keep it as similar to ETABS as possible....so keeping a warning message with same code makes things more consistent across the two packages.

fyi @peterjamesnugent,

it would be great to have this merged by end of the week if possible so that from next week onwards we can start implementing all the missing features we have in our list.
Let me know what are your thoughts and anything is missing I'll make sure to get it done asap.

Thank you both.

[peterjamesnugent]

Can we get someone to test in Rhino 8, specifically to hit this if statement:

SAP2000_Toolkit/SAP2000_Adapter/SAP2000Adapter.cs

Line 62 in ac232b6

Engine.Base.Compute.RecordError($"The SAP2000Adapter is currently not support in NET runtimes above .NETFramework due to internal errors in the SAP2000 API. A fix for this is being worked on. \n" +

[samuelbasimalla]

@GCRA101 @peterjamesnugent
After the changes made, I tested again in both Rhino 7 and Rhino 8 with the same two testing scripts mentioned above in Version 25.1.0 of SAP2000.

name of test scripts: Structures - Create - Read - Update - Elements and Structures - Create non-existing.

All functionality working as intended.

My rhino DotNetRuntime is already set to compatbility framework version 4.xx (did this for ETABS), the reason why it probably works without hitting the if statement mentioned by @peterjamesnugent .

[samuelbasimalla]

After the changes made, I tested again in both Rhino 7 and Rhino 8 with the same two testing scripts mentioned above in Version 25.1.0 of SAP2000.

Name of test scripts: Structures - Create - Read - Update - Elements and Structures - Create non-existing.

All functionality working as intended.

Changes addressed and checks conducted in Rhino 8

[peterjamesnugent]

@BHoMBot check ready-to-merge

[bhombot-ci]

@peterjamesnugent to confirm, the following actions are now queued:

• check ready-to-merge

[peterjamesnugent]

Adding an approving review based on @samuelbasimalla 's comments,

[peterjamesnugent]

@BHoMBot check ready-to-merge

[bhombot-ci]

@peterjamesnugent to confirm, the following actions are now queued:

• check ready-to-merge