Skip to content

Update win-ignoreAllFailures.ps1 to v1.2#130

Open
anmocanu wants to merge 1 commit into
Azure:mainfrom
anmocanu:patch-13
Open

Update win-ignoreAllFailures.ps1 to v1.2#130
anmocanu wants to merge 1 commit into
Azure:mainfrom
anmocanu:patch-13

Conversation

@anmocanu

Copy link
Copy Markdown
Contributor

.VERSION
v1.2: [May 2026] - Updated the script (current)
- Added guarded nested VM handling to prevent Get-VM failures when Hyper-V module is unavailable.
- Switched partition discovery from inline CIM enumeration to shared Get-Disk-Partitions-v2 helper.
- Added .SYNOPSIS header and aligned metadata versioning/documentation with current script behavior.
v1.1: [Apr 2026] - Enhanced CIM logic for disk enumeration and partition discovery
v1.0: Initial commit - Sets BCD boot status policy to IgnoreAllFailures to break Automatic Repair loops

.VERSION
    v1.2: [May 2026] - Updated the script (current)
                       - Added guarded nested VM handling to prevent Get-VM failures when Hyper-V module is unavailable.
                       - Switched partition discovery from inline CIM enumeration to shared Get-Disk-Partitions-v2 helper.
                       - Added .SYNOPSIS header and aligned metadata versioning/documentation with current script behavior.
    v1.1: [Apr 2026] - Enhanced CIM logic for disk enumeration and partition discovery
    v1.0: Initial commit - Sets BCD boot status policy to IgnoreAllFailures to break Automatic Repair loops
@EdwinBernal1

Copy link
Copy Markdown
Member

Issues Found

🟡 Side effect risk: temporary EFI letter assignment not cleaned up

The script mounts hidden EFI partitions with Set-Partition -NewDriveLetter but does not unassign them in cleanup. This can leave unexpected mounted system partitions on rescue hosts.

Recommendation: track newly assigned letters and remove them in finally.

🟢 Minor: hidden partition filter may miss null-letter cases

Filter uses DriveLetter -eq 0 for hidden partitions. Depending on object shape, unlettered partitions can appear as null rather than 0.

Recommendation: include null/empty checks (e.g., -not $_.DriveLetter).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants