[Horizondb] Fix update parameter-group behavior and tests#9952
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @alxhghs, |
|
Horizondb |
|
@alxhghs please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
| self.assertEqual(show_result['properties']['vCores'], v_cores_update) | ||
|
|
||
| # Update cluster parameter group | ||
| parameter_group_id = show_result.get('properties', {}).get('parameterGroup', {}).get('id') |
There was a problem hiding this comment.
Create separate test file that you will expand on later.
test_horizondb_parameter_group
You can create cluster and update the group. Then alter on you calling commands associated to parameter groups.
| - name: Update an existing HorizonDB cluster to have 6 vCores. | ||
| text: az horizondb update --name examplecluster --resource-group exampleresourcegroup --v-cores 6 | ||
| - name: Assign a parameter group to an existing HorizonDB cluster. | ||
| text: az horizondb update --name examplecluster --resource-group exampleresourcegroup --parameter-group /subscriptions/{sub}/resourceGroups/{rg}/providers/Microsoft.HorizonDb/parameterGroups/examplepg |
There was a problem hiding this comment.
--parameter-group /subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.HorizonDb/parameterGroups/{parameterGroup}
| help='Defines how replicas are placed across availability zones.') | ||
|
|
||
| parameter_group_arg_type = CLIArgumentType( | ||
| options_list=['--parameter-group', '--parameter-group-id'], |
|
|
||
| parameter_group_arg_type = CLIArgumentType( | ||
| options_list=['--parameter-group', '--parameter-group-id'], | ||
| help='The resource ID of the parameter group to assign to this cluster.') |
There was a problem hiding this comment.
Make more generic in case reuse
ie. "The resource ID of parameter group."
…management test and add dedicated parameter group scenario test
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.